Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2485793002: Fix IME tray bubble (and other tray bubble views). (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
msw, tdanderson
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org, Azure Wei
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=663192 Committed: https://crrev.com/03f052fcaf93364ce2136172b91137793e4f3458 Cr-Commit-Position: refs/heads/master@{#430500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/views/bubble/bubble_dialog_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Evan Stade
4 years, 1 month ago (2016-11-08 01:25:26 UTC) #3
msw
lgtm
4 years, 1 month ago (2016-11-08 01:32:59 UTC) #4
tdanderson
On 2016/11/08 01:32:59, msw wrote: > lgtm LGTM also
4 years, 1 month ago (2016-11-08 01:45:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485793002/1
4 years, 1 month ago (2016-11-08 01:47:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 03:17:31 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 03:27:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03f052fcaf93364ce2136172b91137793e4f3458
Cr-Commit-Position: refs/heads/master@{#430500}

Powered by Google App Engine
This is Rietveld 408576698