Rename request() method to getRequest().

Rename request() methods in blink namespace to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org, nasko@chromium.org

Committed: https://crrev.com/8f284ba52e557dce90a78e61b9e974428277ee61
Cr-Commit-Position: refs/heads/master@{#439647}

[Łukasz Anforowicz, 2016-12-14 18:24:44]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 18:25:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-12-14 18:27:00]

Description was changed from

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

BUG=582312
==========

to

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
==========

[commit-bot: I haz the power, 2016-12-14 18:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 18:40:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2016-12-14 19:58:29]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 19:59:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:34:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2016-12-15 19:02:00]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 19:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 21:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:33:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2016-12-15 22:30:52]

lukasza@chromium.org changed reviewers:
+ yhirano@chromium.org

[Łukasz Anforowicz, 2016-12-15 22:30:53]

yhirano@, could you PTAL?

Some notes:

- The failure in linux_chromium_rel_ng is in telemetry_unittests and doesn't
seem related to the CL under review

- Unlike similar CLs in the past, this CL doesn't change *all* instances of
"request()" substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.  Still - the
rename should help avoid compiler errors at least in the headers touched by this
CL, so I'd like to land it, to help get Blink closer to a buildable state after
the "big rename".

[yhirano, 2016-12-16 14:52:37]

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:96: const
ResourceRequest& getRequest() const;
Would it be reasonable to make this function inline and keep the name?

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.h (right):

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.h:89: const FetchRequestData*
getRequest() const { return m_request; }
This is an inline trivial getter. My understanding is the google style allows us
to use request() here.

[Łukasz Anforowicz, 2016-12-16 17:15:03]

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:96: const
ResourceRequest& getRequest() const;
On 2016/12/16 14:52:37, yhirano wrote:
> Would it be reasonable to make this function inline and keep the name?

This wouldn't have helped with the problem described in the linked bug and the
CL description - after a naive automated rename, we would still end up with the
same identifier (|Request|) for both a type and a method - such situation leads
to build errors after the automated rename.  This CL will unblock (*) the
automatic rename.

(*) Well, unblock as far as |request| vs |Request| conflict goes.  There are
other issues that cause build errors after the automatic rename.  We are trying
to systematically work through these issues.

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.h (right):

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.h:89: const FetchRequestData*
getRequest() const { return m_request; }
On 2016/12/16 14:52:37, yhirano wrote:
> This is an inline trivial getter. My understanding is the google style allows
us
> to use request() here.

1. We plan to use a clang tool to rewrite most identifiers in Blink to follow
Chromium code style (i.e. my_field instead of m_myField).

2. You are right, that Google style and Chromium style indeed allow to use
request() here.

3. The problem here is that the tool from #1 above is not smart enough to decide
whether it is dealing with |request()| accessor (which should be hacker_case -
i.e. request() wouldn't have to be renamed) or with a |start()| method (that
should be renamed to PascalCased - i.e. to |Start()|).  This means that today
the tool will rewrite all method names to PascalCased style.

4. Rewrite from #3 leads to trouble (i.e. failure to build after the automatic
rename), because it means that Request becomes both 1) a name of a type and 2) a
name of a method.

5. As suggested by esprehn@ in https://crbug.com/582312#c17, we are addressing
#4 by having the following naming policy for accessors: """
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename the type
if it's easy and makes sense, or add "Get", ex. GetContext().
"""

6. This CL is applying the guidance from #5 to one more identifier (similarily
to how earlier CLs for https://crbug.com/582312 introduced getString,
getLoaderMap, getColorFilter, getReferrer, getBlobRegistry and other identifiers
prefixed with "get").

[yhirano, 2016-12-19 10:55:12]

lgtm

[Łukasz Anforowicz, 2016-12-19 17:54:06]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-19 17:54:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:03:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2016-12-19 18:13:18]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-19 18:13:18]

dcheng@, could you please take a look at third_party/WebKit/Source/web (since
there are 2 header files that are changing there)?

[Łukasz Anforowicz, 2016-12-19 18:14:17]

Description was changed from

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
==========

to

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org
==========

[Łukasz Anforowicz, 2016-12-19 18:16:14]

lukasza@chromium.org changed reviewers:
+ melandory@chromium.org, rdevlin.cronin@chromium.org, sky@chromium.org

[Łukasz Anforowicz, 2016-12-19 18:16:15]

sky@, melandory@, rdevlin.cronin@ - I'll TBR you for this CL - the changes under
chrome/, components/subresource_filter/ and extensions/ are a mechanical
consequence of the rename that is being reviewed by yhirano@ and dcheng@.

[Łukasz Anforowicz, 2016-12-19 18:17:19]

Description was changed from

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org
==========

to

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org
==========

[Łukasz Anforowicz, 2016-12-19 18:18:22]

lukasza@chromium.org changed reviewers:
+ nasko@chromium.org

[Łukasz Anforowicz, 2016-12-19 18:18:23]

nasko@ - I am also TBR-ing you for content/ (the changes under content/ are a
mechanical consequence of the rename that is being reviewed by yhirano@ and
dcheng@)

[Devlin, 2016-12-19 18:22:03]

extensions lgtm

[Devlin, 2016-12-19 18:23:04]

though as an optional drive-by nit, it could be good to rename this CL to
something like:
Rename WebDataSource::request() to getRequest()

so that it's clear which of the n request() methods you're renaming. :)

[Łukasz Anforowicz, 2016-12-19 18:26:32]

Description was changed from

==========
Rename request() method to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org
==========

to

==========
Rename request() methods in blink namespace to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org
==========

[Łukasz Anforowicz, 2016-12-19 18:28:27]

On 2016/12/19 18:23:04, Devlin wrote:
> though as an optional drive-by nit, it could be good to rename this CL to
> something like:
> Rename WebDataSource::request() to getRequest()
> 
> so that it's clear which of the n request() methods you're renaming. :)

Good point.  I've changed the CL description to:

    Rename request() methods in blink namespace to getRequest().

(because the CL is not just renaming WebDataSource::request(), but also renaming
other methods named "request" that are under "blink" namespace)

[nasko, 2016-12-19 18:42:16]

content/ LGTM

[haraken, 2016-12-20 00:01:52]

WebKit LGTM

[dcheng, 2016-12-20 00:49:49]

blink lgtm2

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.h (right):

https://codereview.chromium.org/2573523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.h:89: const FetchRequestData*
getRequest() const { return m_request; }
On 2016/12/16 17:15:03, Łukasz Anforowicz wrote:
> On 2016/12/16 14:52:37, yhirano wrote:
> > This is an inline trivial getter. My understanding is the google style
allows
> us
> > to use request() here.
> 
> 1. We plan to use a clang tool to rewrite most identifiers in Blink to follow
> Chromium code style (i.e. my_field instead of m_myField).
> 
> 2. You are right, that Google style and Chromium style indeed allow to use
> request() here.
> 
> 3. The problem here is that the tool from #1 above is not smart enough to
decide
> whether it is dealing with |request()| accessor (which should be hacker_case -
> i.e. request() wouldn't have to be renamed) or with a |start()| method (that
> should be renamed to PascalCased - i.e. to |Start()|).  This means that today
> the tool will rewrite all method names to PascalCased style.
> 
> 4. Rewrite from #3 leads to trouble (i.e. failure to build after the automatic
> rename), because it means that Request becomes both 1) a name of a type and 2)
a
> name of a method.
> 
> 5. As suggested by esprehn@ in https://crbug.com/582312#c17, we are addressing
> #4 by having the following naming policy for accessors: """
> - Getters favor not using "Get", ex. FirstChild()
> - Unless the type name conflicts, in which case you can either rename the type
> if it's easy and makes sense, or add "Get", ex. GetContext().
> """
> 
> 6. This CL is applying the guidance from #5 to one more identifier (similarily
> to how earlier CLs for https://crbug.com/582312 introduced getString,
> getLoaderMap, getColorFilter, getReferrer, getBlobRegistry and other
identifiers
> prefixed with "get").

FWIW, I've asked jyasskin to amend the New Blink Style Guide
(https://docs.google.com/document/d/1ZQLiQKw9hCOyDDhDS4JhckhuiJmLqSbw9FLfySMyx...)
to explicitly permit this.

[Łukasz Anforowicz, 2016-12-20 01:00:04]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:00:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 01:06:59]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482195604711360,
"parent_rev": "09a38a310ace43c3a35cef1f0ada9ff99b913f17", "commit_rev":
"fa08b2cafdb88645ab99e8ed749f67fc29215a57"}

[commit-bot: I haz the power, 2016-12-20 01:08:35]

Description was changed from

==========
Rename request() methods in blink namespace to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org
==========

to

==========
Rename request() methods in blink namespace to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org

Review-Url: https://codereview.chromium.org/2573523002
==========

[commit-bot: I haz the power, 2016-12-20 01:08:36]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-20 01:13:53]

Description was changed from

==========
Rename request() methods in blink namespace to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org

Review-Url: https://codereview.chromium.org/2573523002
==========

to

==========
Rename request() methods in blink namespace to getRequest().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org,
nasko@chromium.org

Committed: https://crrev.com/8f284ba52e557dce90a78e61b9e974428277ee61
Cr-Commit-Position: refs/heads/master@{#439647}
==========

[commit-bot: I haz the power, 2016-12-20 01:13:55]

Patchset 7 (id:??) landed as
https://crrev.com/8f284ba52e557dce90a78e61b9e974428277ee61
Cr-Commit-Position: refs/heads/master@{#439647}