Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2573523002: Rename request() method to getRequest(). (Closed)
Patch Set: Fixing a mistake I've made in USBDevice.cpp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 7cf7d26aa896954080f9615aedf1a4eb2d842441..dad0f585f1c86edd30f5ada2f32b6156a787febb 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -4175,7 +4175,7 @@ TEST_P(ParameterizedWebFrameTest, ReloadWhileProvisional) {
webViewHelper.webView()->mainFrame()->dataSource();
ASSERT_TRUE(dataSource);
EXPECT_EQ(toKURL(m_baseURL + "fixed_layout.html"),
- KURL(dataSource->request().url()));
+ KURL(dataSource->getRequest().url()));
}
TEST_P(ParameterizedWebFrameTest, AppendRedirects) {
@@ -7000,7 +7000,7 @@ TEST_P(ParameterizedWebFrameTest, BackToReload) {
FrameTestHelpers::reloadFrame(frame);
EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
- frame->dataSource()->request().getCachePolicy());
+ frame->dataSource()->getRequest().getCachePolicy());
}
TEST_P(ParameterizedWebFrameTest, BackDuringChildFrameReload) {
@@ -7047,11 +7047,11 @@ TEST_P(ParameterizedWebFrameTest, ReloadPost) {
FrameTestHelpers::pumpPendingRequestsForFrameToLoad(
webViewHelper.webView()->mainFrame());
EXPECT_EQ(WebString::fromUTF8("POST"),
- frame->dataSource()->request().httpMethod());
+ frame->dataSource()->getRequest().httpMethod());
FrameTestHelpers::reloadFrame(frame);
EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
- frame->dataSource()->request().getCachePolicy());
+ frame->dataSource()->getRequest().getCachePolicy());
EXPECT_EQ(WebNavigationTypeFormResubmitted,
frame->dataSource()->navigationType());
}
@@ -7077,7 +7077,7 @@ TEST_P(ParameterizedWebFrameTest, LoadHistoryItemReload) {
WebCachePolicy::ValidatingCacheData);
EXPECT_EQ(firstItem.get(), mainFrameLoader.currentItem());
EXPECT_EQ(WebCachePolicy::ValidatingCacheData,
- frame->dataSource()->request().getCachePolicy());
+ frame->dataSource()->getRequest().getCachePolicy());
}
class TestCachePolicyWebFrameClient
@@ -8339,7 +8339,7 @@ TEST_P(ParameterizedWebFrameTest, ReloadBypassingCache) {
WebFrame* frame = webViewHelper.webView()->mainFrame();
FrameTestHelpers::reloadFrameBypassingCache(frame);
EXPECT_EQ(WebCachePolicy::BypassingCache,
- frame->dataSource()->request().getCachePolicy());
+ frame->dataSource()->getRequest().getCachePolicy());
}
static void nodeImageTestValidation(const IntSize& referenceBitmapSize,

Powered by Google App Engine
This is Rietveld 408576698