Rename request() method to getRequest().

third_party/WebKit/Source/modules/fetch/Request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Request_h
 #define Request_h
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/modules/v8/RequestOrUSVString.h"
@@ skipping 68 matching lines @@
   PassRefPtr<EncodedFormData> attachedCredential() const {
     return m_request->attachedCredential();
   }
 
   DECLARE_VIRTUAL_TRACE();
 
  private:
   Request(ScriptState*, FetchRequestData*, Headers*);
   Request(ScriptState*, FetchRequestData*);
 
-  const FetchRequestData* request() const { return m_request; }
+  const FetchRequestData* getRequest() const { return m_request; }

[yhirano, 2016/12/16 14:52:37]

This is an inline trivial getter. My understanding is the google style allows us
to use request() here.

[Łukasz Anforowicz, 2016/12/16 17:15:03]

1. We plan to use a clang tool to rewrite most identifiers in Blink to follow
Chromium code style (i.e. my_field instead of m_myField).

2. You are right, that Google style and Chromium style indeed allow to use
request() here.

3. The problem here is that the tool from #1 above is not smart enough to decide
whether it is dealing with |request()| accessor (which should be hacker_case -
i.e. request() wouldn't have to be renamed) or with a |start()| method (that
should be renamed to PascalCased - i.e. to |Start()|).  This means that today
the tool will rewrite all method names to PascalCased style.

4. Rewrite from #3 leads to trouble (i.e. failure to build after the automatic
rename), because it means that Request becomes both 1) a name of a type and 2) a
name of a method.

5. As suggested by esprehn@ in https://crbug.com/582312#c17, we are addressing
#4 by having the following naming policy for accessors: """
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename the type
if it's easy and makes sense, or add "Get", ex. GetContext().
"""

6. This CL is applying the guidance from #5 to one more identifier (similarily
to how earlier CLs for https://crbug.com/582312 introduced getString,
getLoaderMap, getColorFilter, getReferrer, getBlobRegistry and other identifiers
prefixed with "get").

[dcheng, 2016/12/20 00:49:49]

FWIW, I've asked jyasskin to amend the New Blink Style Guide
(https://docs.google.com/document/d/1ZQLiQKw9hCOyDDhDS4JhckhuiJmLqSbw9FLfySMyx...)
to explicitly permit this.

   static Request* createRequestWithRequestOrString(ScriptState*,
                                                    Request*,
                                                    const String&,
                                                    RequestInit&,
                                                    ExceptionState&);
 
   String mimeType() const override;
   void refreshBody(ScriptState*);
 
   const Member<FetchRequestData> m_request;
   const Member<Headers> m_headers;
 };
 
 }  // namespace blink
 
 #endif  // Request_h