Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.cc

Issue 2573423002: [DevTools] Remove old generator in content. (Closed)
Patch Set: fixed review comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.cc
diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc
index 530f297df6626193fb2a02419307d738209ba487..f09727799a94ab48dce47cb8ef1b775850268e2c 100644
--- a/content/browser/devtools/devtools_agent_host_impl.cc
+++ b/content/browser/devtools/devtools_agent_host_impl.cc
@@ -15,7 +15,7 @@
#include "content/browser/devtools/devtools_manager.h"
#include "content/browser/devtools/devtools_session.h"
#include "content/browser/devtools/forwarding_agent_host.h"
-#include "content/browser/devtools/protocol/devtools_protocol_dispatcher.h"
+#include "content/browser/devtools/protocol/page.h"
#include "content/browser/devtools/render_frame_devtools_agent_host.h"
#include "content/browser/devtools/service_worker_devtools_agent_host.h"
#include "content/browser/devtools/service_worker_devtools_manager.h"
@@ -47,12 +47,14 @@ int DevToolsAgentHostImpl::s_force_creation_count_ = 0;
// static
std::string DevToolsAgentHost::GetProtocolVersion() {
- return std::string(devtools::kProtocolVersion);
+ // TODO(dgozman): generate this.
+ return "1.2";
}
// static
bool DevToolsAgentHost::IsSupportedProtocolVersion(const std::string& version) {
- return devtools::IsSupportedProtocolVersion(version);
+ // TODO(dgozman): generate this.
+ return version == "1.0" || version == "1.1" || version == "1.2";
}
// static
@@ -246,16 +248,6 @@ bool DevToolsAgentHostImpl::Inspect() {
return false;
}
-void DevToolsAgentHostImpl::SendProtocolResponse(int session_id,
- const std::string& message) {
- SendMessageToClient(session_id, message);
-}
-
-void DevToolsAgentHostImpl::SendProtocolNotification(
- const std::string& message) {
- SendMessageToClient(session_ ? session_->session_id() : 0, message);
-}
-
void DevToolsAgentHostImpl::HostClosed() {
if (!client_)
return;
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.h ('k') | content/browser/devtools/devtools_protocol_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698