Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.cc

Issue 2573423002: [DevTools] Remove old generator in content. (Closed)
Patch Set: fixed review comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_client.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_client.cc b/content/browser/devtools/protocol/devtools_protocol_client.cc
deleted file mode 100644
index 5f132d92cb7c9571a0cc527ca219f3d165e2af5d..0000000000000000000000000000000000000000
--- a/content/browser/devtools/protocol/devtools_protocol_client.cc
+++ /dev/null
@@ -1,145 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "content/browser/devtools/protocol/devtools_protocol_client.h"
-
-#include "base/json/json_writer.h"
-#include "base/strings/stringprintf.h"
-#include "content/browser/devtools/protocol/devtools_protocol_delegate.h"
-
-namespace content {
-
-namespace {
-
-const char kIdParam[] = "id";
-const char kMethodParam[] = "method";
-const char kParamsParam[] = "params";
-const char kResultParam[] = "result";
-const char kErrorParam[] = "error";
-const char kErrorCodeParam[] = "code";
-const char kErrorMessageParam[] = "message";
-
-// Special values.
-const int kStatusOk = -1;
-const int kStatusFallThrough = -2;
-// JSON RPC 2.0 spec: http://www.jsonrpc.org/specification#error_object
-const int kStatusInvalidParams = -32602;
-const int kStatusInternalError = -32603;
-const int kStatusServerError = -32000;
-
-} // namespace
-
-// static
-const int DevToolsCommandId::kNoId = -1;
-
-DevToolsProtocolClient::DevToolsProtocolClient(
- DevToolsProtocolDelegate* notifier)
- : notifier_(notifier) {}
-
-DevToolsProtocolClient::~DevToolsProtocolClient() {
-}
-
-void DevToolsProtocolClient::SendRawNotification(const std::string& message) {
- notifier_->SendProtocolNotification(message);
-}
-
-void DevToolsProtocolClient::SendMessage(int session_id,
- const base::DictionaryValue& message) {
- std::string json_message;
- base::JSONWriter::Write(message, &json_message);
- notifier_->SendProtocolResponse(session_id, json_message);
-}
-
-void DevToolsProtocolClient::SendNotification(
- const std::string& method,
- std::unique_ptr<base::DictionaryValue> params) {
- base::DictionaryValue notification;
- notification.SetString(kMethodParam, method);
- if (params)
- notification.Set(kParamsParam, params.release());
-
- std::string json_message;
- base::JSONWriter::Write(notification, &json_message);
- SendRawNotification(json_message);
-}
-
-void DevToolsProtocolClient::SendSuccess(
- DevToolsCommandId command_id,
- std::unique_ptr<base::DictionaryValue> params) {
- base::DictionaryValue response;
- response.SetInteger(kIdParam, command_id.call_id);
-
- response.Set(kResultParam,
- params ? params.release() : new base::DictionaryValue());
-
- SendMessage(command_id.session_id, response);
-}
-
-bool DevToolsProtocolClient::SendError(DevToolsCommandId command_id,
- const Response& response) {
- if (response.status() == kStatusOk ||
- response.status() == kStatusFallThrough) {
- return false;
- }
- base::DictionaryValue dict;
- if (command_id.call_id == DevToolsCommandId::kNoId)
- dict.Set(kIdParam, base::Value::CreateNullValue());
- else
- dict.SetInteger(kIdParam, command_id.call_id);
-
- base::DictionaryValue* error_object = new base::DictionaryValue();
- error_object->SetInteger(kErrorCodeParam, response.status());
- if (!response.message().empty())
- error_object->SetString(kErrorMessageParam, response.message());
-
- dict.Set(kErrorParam, error_object);
- SendMessage(command_id.session_id, dict);
- return true;
-}
-
-typedef DevToolsProtocolClient::Response Response;
-
-Response Response::FallThrough() {
- return Response(kStatusFallThrough);
-}
-
-Response Response::OK() {
- return Response(kStatusOk);
-}
-
-Response Response::InvalidParams(const std::string& param) {
- return Response(kStatusInvalidParams,
- base::StringPrintf("Missing or invalid '%s' parameter", param.c_str()));
-}
-
-Response Response::InternalError(const std::string& message) {
- return Response(kStatusInternalError, message);
-}
-
-Response Response::ServerError(const std::string& message) {
- return Response(kStatusServerError, message);
-}
-
-int Response::status() const {
- return status_;
-}
-
-const std::string& Response::message() const {
- return message_;
-}
-
-bool Response::IsFallThrough() const {
- return status_ == kStatusFallThrough;
-}
-
-Response::Response(int status)
- : status_(status) {
-}
-
-Response::Response(int status, const std::string& message)
- : status_(status),
- message_(message) {
-}
-
-} // namespace content

Powered by Google App Engine
This is Rietveld 408576698