Remove unused sysbtn code

Remove unused sysbtn code

This CL removes the unused FWL_WGTSTYLE_MinimizeBox, FWL_WGTSTYLE_MaximizeBox,
and FWL_WGTSTYLE_CloseBox along with the supporting code.

Review-Url: https://codereview.chromium.org/2578603002
Committed: https://pdfium.googlesource.com/pdfium/+/ea7657c883f3bcf9136c00b46450ca4053bee766

[dsinclair, 2016-12-14 14:56:45]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 14:56:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 15:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:07:05]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-14 16:18:03]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-14 16:18:04]

PTAL.

[Tom Sepez, 2016-12-14 17:29:27]

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h
File xfa/fwl/fwl_widgetdef.h (right):

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:10: #define FWL_WGTSTYLE_OverLapper 0
Again, we've got a 2-bit field starting at 0.  How to communicate that in code? 
There ought to be a mask constant here that's part of how this is used ....

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:17: #define FWL_WGTSTYLE_LeftAlignment (0L << 13)
ditto here, except they're unused?

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:21: #define FWL_WGTSTYLE_VCenterAlignment (1L << 15)
and here, unused.

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:37: #define FWL_WGTSTYLE_WindowTypeMask (3L << 0)
and here it is!  the mask constant, move to line 13.

[dsinclair, 2016-12-14 17:48:13]

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h
File xfa/fwl/fwl_widgetdef.h (right):

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:10: #define FWL_WGTSTYLE_OverLapper 0
On 2016/12/14 17:29:27, Tom Sepez wrote:
> Again, we've got a 2-bit field starting at 0.  How to communicate that in
code? 
> There ought to be a mask constant here that's part of how this is used ....

This file is cleaned up over several CLs. I'll shuffle this around at the end
...

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:17: #define FWL_WGTSTYLE_LeftAlignment (0L << 13)
On 2016/12/14 17:29:27, Tom Sepez wrote:
> ditto here, except they're unused?

Acknowledged.

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:21: #define FWL_WGTSTYLE_VCenterAlignment (1L << 15)
On 2016/12/14 17:29:27, Tom Sepez wrote:
> and here, unused.

Acknowledged.

https://codereview.chromium.org/2578603002/diff/1/xfa/fwl/fwl_widgetdef.h#new...
xfa/fwl/fwl_widgetdef.h:37: #define FWL_WGTSTYLE_WindowTypeMask (3L << 0)
On 2016/12/14 17:29:27, Tom Sepez wrote:
> and here it is!  the mask constant, move to line 13.

Acknowledged.

[dsinclair, 2016-12-15 13:56:38]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 13:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-15 13:57:10]

ping

[commit-bot: I haz the power, 2016-12-15 14:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:06:52]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-15 17:52:28]

lgtm

[dsinclair, 2016-12-15 18:32:02]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:32:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 18:32:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481826722594820,
"parent_rev": "72a22025ec4402178cd0b27239bf77cf3a953949", "commit_rev":
"ea7657c883f3bcf9136c00b46450ca4053bee766"}

[commit-bot: I haz the power, 2016-12-15 18:32:29]

Description was changed from

==========
Remove unused sysbtn code

This CL removes the unused FWL_WGTSTYLE_MinimizeBox, FWL_WGTSTYLE_MaximizeBox,
and FWL_WGTSTYLE_CloseBox along with the supporting code.
==========

to

==========
Remove unused sysbtn code

This CL removes the unused FWL_WGTSTYLE_MinimizeBox, FWL_WGTSTYLE_MaximizeBox,
and FWL_WGTSTYLE_CloseBox along with the supporting code.

Review-Url: https://codereview.chromium.org/2578603002
Committed:
https://pdfium.googlesource.com/pdfium/+/ea7657c883f3bcf9136c00b46450ca4053be...
==========

[commit-bot: I haz the power, 2016-12-15 18:32:30]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/ea7657c883f3bcf9136c00b46450ca4053be...