Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2572653003: [DevTools] Migrate security handler to new generator. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate security handler to new generator. Attempt 2. Previous one was reverted due to build failure in headless. BUG=664683 TBR=pfeldman Committed: https://crrev.com/581dd5b76aded0c3cedc5bd8a384a8e9a84458ef Cr-Commit-Position: refs/heads/master@{#438376}

Patch Set 1 #

Patch Set 2 : upstream fix #

Patch Set 3 : no protocol changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -78 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/devtools/protocol/security_handler.h View 2 chunks +15 lines, -16 lines 0 comments Download
M content/browser/devtools/protocol/security_handler.cc View 1 2 7 chunks +50 lines, -52 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 4 chunks +10 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (16 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-13 18:10:47 UTC) #2
caseq
lgtm
4 years ago (2016-12-13 18:43:25 UTC) #5
dgozman
TBR'ing pfeldman for BUILD.gn
4 years ago (2016-12-13 18:52:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572653003/20001
4 years ago (2016-12-13 18:53:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 20:05:09 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9bbce3fd6a435ee5950e9cfd069cfdd9ea2596b6 Cr-Commit-Position: refs/heads/master@{#438267}
4 years ago (2016-12-13 20:07:56 UTC) #15
dgozman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2567343003/ by dgozman@chromium.org. ...
4 years ago (2016-12-13 20:22:08 UTC) #16
findit-for-me
FYI: Findit identified this CL at revision 438267 as the culprit for failures in the ...
4 years ago (2016-12-13 20:41:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572653003/40001
4 years ago (2016-12-14 00:01:40 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 01:16:19 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-14 01:18:24 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/581dd5b76aded0c3cedc5bd8a384a8e9a84458ef
Cr-Commit-Position: refs/heads/master@{#438376}

Powered by Google App Engine
This is Rietveld 408576698