[DevTools] Migrate storage domain to new generator.

[DevTools] Migrate storage domain to new generator.

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/d5a5b2c6c80706ce3ca3c691071aefb068f808f9
Cr-Commit-Position: refs/heads/master@{#438611}

[dgozman, 2016-12-14 00:15:39]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-12-14 00:15:40]

Could you please take a look?

[caseq, 2016-12-14 00:47:32]

lgtm

[dgozman, 2016-12-14 05:13:16]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 05:13:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 06:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 06:09:23]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-14 06:44:56]

Description was changed from

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
==========

to

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-12-14 06:45:08]

TBR'ing pfeldman for BUILD.gn

[dgozman, 2016-12-14 06:45:13]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-14 06:45:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 06:49:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481697913464000, "parent_rev":
"f11aed415beed4a26e2f7c804e484ae71a4683e8", "commit_rev":
"566169ab82ca330f7b72ec8159f2b1715be24810"}

[commit-bot: I haz the power, 2016-12-14 06:50:44]

Description was changed from

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2572933002
==========

[commit-bot: I haz the power, 2016-12-14 06:50:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 06:52:22]

Description was changed from

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2572933002
==========

to

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
Cr-Commit-Position: refs/heads/master@{#438449}
==========

[commit-bot: I haz the power, 2016-12-14 06:52:23]

Patchset 1 (id:??) landed as
https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
Cr-Commit-Position: refs/heads/master@{#438449}

[tommycli, 2016-12-14 17:22:32]

On 2016/12/14 06:52:23, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
> Cr-Commit-Position: refs/heads/master@{#438449}

Hey, I'm almost certain this breaks Lighthouse.

I get errors like this after this revision:
Runtime error encountered: Error: Protocol error (Storage.clearDataForOrigin):
Internal error
    at CriConnection.handleRawError
(/usr/local/google/home/tommycli/local/lib/node_modules/lighthouse/lighthouse-core/gather/connections/connection.js:132:11)
    at callback.resolve.Promise.resolve.then._
(/usr/local/google/home/tommycli/local/lib/node_modules/lighthouse/lighthouse-core/gather/connections/connection.js:101:23)
Error: Protocol error (Storage.clearDataForOrigin): Internal error
    at CriConnection.handleRawError
(/usr/local/google/home/tommycli/local/lib/node_modules/lighthouse/lighthouse-core/gather/connections/connection.js:132:11)
    at callback.resolve.Promise.resolve.then._
(/usr/local/google/home/tommycli/local/lib/node_modules/lighthouse/lighthouse-core/gather/connections/connection.js:101:23)

[tommycli, 2016-12-14 17:37:33]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2576643003/ by tommycli@chromium.org.

The reason for reverting is: Manually confirmed that this patch breaks
Lighthouse..

[dgozman, 2016-12-14 19:07:15]

Description was changed from

==========
[DevTools] Migrate storage domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
Cr-Commit-Position: refs/heads/master@{#438449}
==========

to

==========
[DevTools] Migrate storage domain to new generator.

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-12-14 19:07:20]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-14 19:07:20]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2572933002/#ps20001
(title: "fixed")

[commit-bot: I haz the power, 2016-12-14 19:08:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:37:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481742440008090,
"parent_rev": "402016d4f0ef75ed562202a21f1e2e462e266182", "commit_rev":
"e4a290e5f5092a349e59f588396e9f3bcfc91be4"}

[commit-bot: I haz the power, 2016-12-14 20:38:02]

Description was changed from

==========
[DevTools] Migrate storage domain to new generator.

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Migrate storage domain to new generator.

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2572933002
==========

[commit-bot: I haz the power, 2016-12-14 20:38:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 20:40:13]

Description was changed from

==========
[DevTools] Migrate storage domain to new generator.

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2572933002
==========

to

==========
[DevTools] Migrate storage domain to new generator.

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/d5a5b2c6c80706ce3ca3c691071aefb068f808f9
Cr-Commit-Position: refs/heads/master@{#438611}
==========

[commit-bot: I haz the power, 2016-12-14 20:40:14]

Patchset 2 (id:??) landed as
https://crrev.com/d5a5b2c6c80706ce3ca3c691071aefb068f808f9
Cr-Commit-Position: refs/heads/master@{#438611}