Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2567343003: Revert of [DevTools] Migrate security handler to new generator. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate security handler to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2572653003/ ) Reason for revert: Breaks build: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/75946 Original issue's description: > [DevTools] Migrate security handler to new generator. > > BUG=664683 > TBR=pfeldman > > Committed: https://crrev.com/9bbce3fd6a435ee5950e9cfd069cfdd9ea2596b6 > Cr-Commit-Position: refs/heads/master@{#438267} TBR=caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664683 Committed: https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249 Cr-Commit-Position: refs/heads/master@{#438276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -91 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/security_handler.h View 2 chunks +16 lines, -15 lines 0 comments Download
M content/browser/devtools/protocol/security_handler.cc View 7 chunks +50 lines, -48 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dgozman
Created Revert of [DevTools] Migrate security handler to new generator.
4 years ago (2016-12-13 20:22:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567343003/1
4 years ago (2016-12-13 20:22:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 20:23:53 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 20:25:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249
Cr-Commit-Position: refs/heads/master@{#438276}

Powered by Google App Engine
This is Rietveld 408576698