Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp

Issue 2572603002: ABANDONED CL: Rename readyState() to getReadyState(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
index 40bf6d2d60d8170a1ee32761932a4f93e71b3905..23186087c89e2e72abf47bcb8d40383e2627a4df 100644
--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
@@ -112,7 +112,7 @@ void XMLHttpRequestProgressEventThrottle::dispatchProgressEvent(
void XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent(
Event* event,
DeferredEventAction action) {
- XMLHttpRequest::State state = m_target->readyState();
+ XMLHttpRequest::State state = m_target->getReadyState();
// Given that ResourceDispatcher doesn't deliver an event when suspended,
// we don't have to worry about event dispatching while suspended.
if (action == Flush) {
@@ -126,7 +126,7 @@ void XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent(
}
m_hasDispatchedProgressProgressEvent = false;
- if (state == m_target->readyState()) {
+ if (state == m_target->getReadyState()) {
// We don't dispatch the event when an event handler associated with
// the previously dispatched event changes the readyState (e.g. when
// the event handler calls xhr.abort()). In such cases a
@@ -139,8 +139,8 @@ void XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent(
void XMLHttpRequestProgressEventThrottle::dispatchProgressProgressEvent(
Event* progressEvent) {
- XMLHttpRequest::State state = m_target->readyState();
- if (m_target->readyState() == XMLHttpRequest::kLoading &&
+ XMLHttpRequest::State state = m_target->getReadyState();
+ if (m_target->getReadyState() == XMLHttpRequest::kLoading &&
m_hasDispatchedProgressProgressEvent) {
TRACE_EVENT1("devtools.timeline", "XHRReadyStateChange", "data",
InspectorXhrReadyStateChangeEvent::data(
@@ -153,7 +153,7 @@ void XMLHttpRequestProgressEventThrottle::dispatchProgressProgressEvent(
InspectorUpdateCountersEvent::data());
}
- if (m_target->readyState() != state)
+ if (m_target->getReadyState() != state)
return;
m_hasDispatchedProgressProgressEvent = true;

Powered by Google App Engine
This is Rietveld 408576698