Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2571763003: Reduce FakeArcBridgeService usage. (Closed)

Created:
4 years ago by hidehiko
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce FakeArcBridgeService usage. We'll extract a part of ArcBridgeService to run ArcSession into a dedicated class. As its preparation, this CL reduces the usage of FakeArcBridgeService, from where RequestStart() RequestStop() or OnShutdown() is not used. Alternatively, ArcBridgeService is now directly instantiated, if the instance's RequestStart(), RequestStop() or OnShutdown() are not accessed. BUG=657687 BUG=b/31079732 TEST=Ran bots. Committed: https://crrev.com/e6d8a9e5c89bacf4b77c5f1ddfa4580741561ed1 Cr-Commit-Position: refs/heads/master@{#438417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -61 lines) Patch
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M components/arc/arc_bridge_service.h View 3 chunks +4 lines, -5 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M components/arc/ime/arc_ime_service_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M components/arc/test/fake_arc_bridge_service.h View 1 chunk +1 line, -4 lines 0 comments Download
M components/arc/test/fake_arc_bridge_service.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/arc/notification/arc_notification_manager_unittest.cc View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
hidehiko
PTAL. This is preparation to extract ARC session running part from ArcBridgeService. lhchavez@: c/b/c/arc, components/arc ...
4 years ago (2016-12-13 17:44:14 UTC) #6
Luis Héctor Chávez
lgtm
4 years ago (2016-12-13 17:52:28 UTC) #7
Georges Khalil
chrome/browser/memory/ LGTM
4 years ago (2016-12-13 18:29:10 UTC) #8
yoshiki
ui/arc/notifications lgtm
4 years ago (2016-12-14 01:45:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571763003/1
4 years ago (2016-12-14 03:39:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 03:45:42 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 03:47:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6d8a9e5c89bacf4b77c5f1ddfa4580741561ed1
Cr-Commit-Position: refs/heads/master@{#438417}

Powered by Google App Engine
This is Rietveld 408576698