Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: components/arc/ime/arc_ime_service_unittest.cc

Issue 2571763003: Reduce FakeArcBridgeService usage. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/ime/arc_ime_service_unittest.cc
diff --git a/components/arc/ime/arc_ime_service_unittest.cc b/components/arc/ime/arc_ime_service_unittest.cc
index 6b976d323c08b083b3d234110dddc3ef230026b5..d5aac38091d94fc474bd17851207e3b1dff242e8 100644
--- a/components/arc/ime/arc_ime_service_unittest.cc
+++ b/components/arc/ime/arc_ime_service_unittest.cc
@@ -133,26 +133,26 @@ class ArcImeServiceTest : public testing::Test {
ArcImeServiceTest() {}
protected:
- std::unique_ptr<FakeArcBridgeService> fake_arc_bridge_service_;
+ std::unique_ptr<ArcBridgeService> arc_bridge_service_;
std::unique_ptr<FakeInputMethod> fake_input_method_;
std::unique_ptr<ArcImeService> instance_;
FakeArcImeBridge* fake_arc_ime_bridge_; // Owned by |instance_|
private:
void SetUp() override {
- fake_arc_bridge_service_.reset(new FakeArcBridgeService);
- instance_.reset(new ArcImeService(fake_arc_bridge_service_.get()));
- fake_arc_ime_bridge_ = new FakeArcImeBridge;
+ arc_bridge_service_ = base::MakeUnique<ArcBridgeService>();
+ instance_ = base::MakeUnique<ArcImeService>(arc_bridge_service_.get());
+ fake_arc_ime_bridge_ = new FakeArcImeBridge();
instance_->SetImeBridgeForTesting(base::WrapUnique(fake_arc_ime_bridge_));
- fake_input_method_.reset(new FakeInputMethod);
+ fake_input_method_ = base::MakeUnique<FakeInputMethod>();
instance_->SetInputMethodForTesting(fake_input_method_.get());
}
void TearDown() override {
fake_arc_ime_bridge_ = nullptr;
instance_.reset();
- fake_arc_bridge_service_.reset();
+ arc_bridge_service_.reset();
}
};

Powered by Google App Engine
This is Rietveld 408576698