Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: components/arc/ime/arc_ime_service_unittest.cc

Issue 2571763003: Reduce FakeArcBridgeService usage. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/ime/arc_ime_service.h" 5 #include "components/arc/ime/arc_ime_service.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 std::set<int> arc_toplevel_window_id_; 126 std::set<int> arc_toplevel_window_id_;
127 }; 127 };
128 128
129 } // namespace 129 } // namespace
130 130
131 class ArcImeServiceTest : public testing::Test { 131 class ArcImeServiceTest : public testing::Test {
132 public: 132 public:
133 ArcImeServiceTest() {} 133 ArcImeServiceTest() {}
134 134
135 protected: 135 protected:
136 std::unique_ptr<FakeArcBridgeService> fake_arc_bridge_service_; 136 std::unique_ptr<ArcBridgeService> arc_bridge_service_;
137 std::unique_ptr<FakeInputMethod> fake_input_method_; 137 std::unique_ptr<FakeInputMethod> fake_input_method_;
138 std::unique_ptr<ArcImeService> instance_; 138 std::unique_ptr<ArcImeService> instance_;
139 FakeArcImeBridge* fake_arc_ime_bridge_; // Owned by |instance_| 139 FakeArcImeBridge* fake_arc_ime_bridge_; // Owned by |instance_|
140 140
141 private: 141 private:
142 void SetUp() override { 142 void SetUp() override {
143 fake_arc_bridge_service_.reset(new FakeArcBridgeService); 143 arc_bridge_service_ = base::MakeUnique<ArcBridgeService>();
144 instance_.reset(new ArcImeService(fake_arc_bridge_service_.get())); 144 instance_ = base::MakeUnique<ArcImeService>(arc_bridge_service_.get());
145 fake_arc_ime_bridge_ = new FakeArcImeBridge; 145 fake_arc_ime_bridge_ = new FakeArcImeBridge();
146 instance_->SetImeBridgeForTesting(base::WrapUnique(fake_arc_ime_bridge_)); 146 instance_->SetImeBridgeForTesting(base::WrapUnique(fake_arc_ime_bridge_));
147 147
148 fake_input_method_.reset(new FakeInputMethod); 148 fake_input_method_ = base::MakeUnique<FakeInputMethod>();
149 instance_->SetInputMethodForTesting(fake_input_method_.get()); 149 instance_->SetInputMethodForTesting(fake_input_method_.get());
150 } 150 }
151 151
152 void TearDown() override { 152 void TearDown() override {
153 fake_arc_ime_bridge_ = nullptr; 153 fake_arc_ime_bridge_ = nullptr;
154 instance_.reset(); 154 instance_.reset();
155 fake_arc_bridge_service_.reset(); 155 arc_bridge_service_.reset();
156 } 156 }
157 }; 157 };
158 158
159 TEST_F(ArcImeServiceTest, HasCompositionText) { 159 TEST_F(ArcImeServiceTest, HasCompositionText) {
160 ui::CompositionText composition; 160 ui::CompositionText composition;
161 composition.text = base::UTF8ToUTF16("nonempty text"); 161 composition.text = base::UTF8ToUTF16("nonempty text");
162 162
163 EXPECT_FALSE(instance_->HasCompositionText()); 163 EXPECT_FALSE(instance_->HasCompositionText());
164 164
165 instance_->SetCompositionText(composition); 165 instance_->SetCompositionText(composition);
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 EXPECT_EQ(instance_.get(), fake_input_method_->GetTextInputClient()); 247 EXPECT_EQ(instance_.get(), fake_input_method_->GetTextInputClient());
248 EXPECT_EQ(2, fake_input_method_->count_set_focused_text_input_client()); 248 EXPECT_EQ(2, fake_input_method_->count_set_focused_text_input_client());
249 249
250 // Focus is moving out. 250 // Focus is moving out.
251 instance_->OnWindowFocused(nullptr, arc_win1.get()); 251 instance_->OnWindowFocused(nullptr, arc_win1.get());
252 EXPECT_EQ(nullptr, fake_input_method_->GetTextInputClient()); 252 EXPECT_EQ(nullptr, fake_input_method_->GetTextInputClient());
253 EXPECT_EQ(2, fake_input_method_->count_set_focused_text_input_client()); 253 EXPECT_EQ(2, fake_input_method_->count_set_focused_text_input_client());
254 } 254 }
255 255
256 } // namespace arc 256 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698