Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2571513003: InstalledAppController should use ContextLifecycleObserver instead of DOMWindowProperty (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

InstalledAppController should use ContextLifecycleObserver instead of DOMWindowProperty DOMWindowProperty::frameDestroyed is now equivalent to ContextLifecycleObserver::contextDestroyed. This CL does the replacement for InstalledAppController. BUG=610176 Committed: https://crrev.com/4256ecc52fd229daa6e9c7aff0ccbe275cb71a49 Cr-Commit-Position: refs/heads/master@{#438123}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/installedapp/InstalledAppController.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
haraken
PTAL
4 years ago (2016-12-13 07:35:11 UTC) #2
sof
lgtm update the description, changing the last occurrence of InstalledAppController to be ContextLifecycleObserver instead. (The ...
4 years ago (2016-12-13 08:27:33 UTC) #3
haraken
> update the description, changing the last occurrence of InstalledAppController > to be ContextLifecycleObserver instead. ...
4 years ago (2016-12-13 08:45:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571513003/20001
4 years ago (2016-12-13 08:45:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 11:20:45 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 11:22:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4256ecc52fd229daa6e9c7aff0ccbe275cb71a49
Cr-Commit-Position: refs/heads/master@{#438123}

Powered by Google App Engine
This is Rietveld 408576698