Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: third_party/WebKit/Source/modules/installedapp/InstalledAppController.h

Issue 2571513003: InstalledAppController should use ContextLifecycleObserver instead of DOMWindowProperty (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
diff --git a/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h b/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
index 8f16da696962d8135aba7427ae24a22d38e6bd43..974fc6f583519ba41a4b9e197b73e864c3a15cf0 100644
--- a/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
+++ b/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
@@ -5,7 +5,7 @@
#ifndef InstalledAppController_h
#define InstalledAppController_h
-#include "core/frame/DOMWindowProperty.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/frame/LocalFrame.h"
#include "modules/ModulesExport.h"
#include "platform/Supplementable.h"
@@ -18,7 +18,7 @@ class WebSecurityOrigin;
class MODULES_EXPORT InstalledAppController final
: public GarbageCollectedFinalized<InstalledAppController>,
public Supplement<LocalFrame>,
- public DOMWindowProperty {
+ public ContextLifecycleObserver {
USING_GARBAGE_COLLECTED_MIXIN(InstalledAppController);
WTF_MAKE_NONCOPYABLE(InstalledAppController);
@@ -37,8 +37,8 @@ class MODULES_EXPORT InstalledAppController final
private:
InstalledAppController(LocalFrame&, WebInstalledAppClient*);
- // Inherited from DOMWindowProperty.
- void frameDestroyed() override;
+ // Inherited from ContextLifecycleObserver.
+ void contextDestroyed() override;
WebInstalledAppClient* m_client;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698