Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp

Issue 2571513003: InstalledAppController should use ContextLifecycleObserver instead of DOMWindowProperty (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/installedapp/InstalledAppController.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
diff --git a/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp b/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
index 16346d0ec7438a68c0b2424cc6e75b883e5cdbdb..bd845355f3383f1ae790a4f93bd3ae0085e2a108 100644
--- a/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
+++ b/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
@@ -4,6 +4,7 @@
#include "modules/installedapp/InstalledAppController.h"
+#include "core/dom/Document.h"
#include "core/frame/LocalFrame.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "public/platform/WebSecurityOrigin.h"
@@ -32,7 +33,7 @@ InstalledAppController* InstalledAppController::from(LocalFrame& frame) {
InstalledAppController::InstalledAppController(LocalFrame& frame,
WebInstalledAppClient* client)
- : DOMWindowProperty(&frame), m_client(client) {}
+ : ContextLifecycleObserver(frame.document()), m_client(client) {}
const char* InstalledAppController::supplementName() {
return "InstalledAppController";
@@ -51,14 +52,13 @@ void InstalledAppController::getInstalledApps(
m_client->getInstalledRelatedApps(url, std::move(callback));
}
-void InstalledAppController::frameDestroyed() {
+void InstalledAppController::contextDestroyed() {
m_client = nullptr;
- DOMWindowProperty::frameDestroyed();
}
DEFINE_TRACE(InstalledAppController) {
Supplement<LocalFrame>::trace(visitor);
- DOMWindowProperty::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/installedapp/InstalledAppController.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698