Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2570923002: Makes AudioOutputDispatcher non-ref-counted. (Closed)

Created:
4 years ago by alokp
Modified:
4 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, Max Morin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes AudioOutputDispatcher non-ref-counted. AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy no longer holds a strong reference to AudioOutputDispatcher. This means dispatcher instances will be deleted when AudioManager shuts down and fire CHECKs for any open proxy streams. BUG=608049 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1873f1437ee75eeca154753660b33ff2336509f0 Cr-Commit-Position: refs/heads/master@{#438285}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -75 lines) Patch
M media/audio/audio_manager_base.cc View 4 chunks +11 lines, -14 lines 0 comments Download
M media/audio/audio_output_dispatcher.h View 3 chunks +2 lines, -9 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 3 chunks +1 line, -5 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 2 chunks +6 lines, -18 lines 2 comments Download
M media/audio/audio_output_proxy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M media/audio/audio_output_resampler.h View 4 chunks +2 lines, -6 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 4 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
alokp
4 years ago (2016-12-13 18:44:02 UTC) #5
DaleCurtis
Thanks! lgtm https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_dispatcher_impl.cc File media/audio/audio_output_dispatcher_impl.cc (right): https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_dispatcher_impl.cc#newcode45 media/audio/audio_output_dispatcher_impl.cc:45: CHECK(proxy_to_physical_map_.empty()); Probably this will cause the CHECK() ...
4 years ago (2016-12-13 20:27:55 UTC) #8
alokp
https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_dispatcher_impl.cc File media/audio/audio_output_dispatcher_impl.cc (right): https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_dispatcher_impl.cc#newcode45 media/audio/audio_output_dispatcher_impl.cc:45: CHECK(proxy_to_physical_map_.empty()); On 2016/12/13 20:27:55, DaleCurtis wrote: > Probably this ...
4 years ago (2016-12-13 20:29:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570923002/1
4 years ago (2016-12-13 20:30:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 21:39:29 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 21:43:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1873f1437ee75eeca154753660b33ff2336509f0
Cr-Commit-Position: refs/heads/master@{#438285}

Powered by Google App Engine
This is Rietveld 408576698