Makes AudioOutputDispatcher non-ref-counted.

Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1873f1437ee75eeca154753660b33ff2336509f0
Cr-Commit-Position: refs/heads/master@{#438285}

[alokp, 2016-12-13 18:41:03]

Description was changed from

==========
Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
==========

to

==========
Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[alokp, 2016-12-13 18:41:27]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 18:42:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alokp, 2016-12-13 18:44:02]

alokp@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:20:17]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-12-13 20:27:55]

Thanks! lgtm

https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_di...
File media/audio/audio_output_dispatcher_impl.cc (right):

https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_di...
media/audio/audio_output_dispatcher_impl.cc:45:
CHECK(proxy_to_physical_map_.empty());
Probably this will cause the CHECK() failures we're seeing to move to here.

[alokp, 2016-12-13 20:29:32]

https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_di...
File media/audio/audio_output_dispatcher_impl.cc (right):

https://codereview.chromium.org/2570923002/diff/1/media/audio/audio_output_di...
media/audio/audio_output_dispatcher_impl.cc:45:
CHECK(proxy_to_physical_map_.empty());
On 2016/12/13 20:27:55, DaleCurtis wrote:
> Probably this will cause the CHECK() failures we're seeing to move to here.

Yes

[alokp, 2016-12-13 20:29:55]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:38:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481660995828500, "parent_rev":
"3ec15e41a604caa10ff126496e2333ef25cc6097", "commit_rev":
"27c2db1f78cd920987da9a962aab4868dc7e985f"}

[commit-bot: I haz the power, 2016-12-13 21:39:28]

Description was changed from

==========
Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2570923002
==========

[commit-bot: I haz the power, 2016-12-13 21:39:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 21:43:38]

Description was changed from

==========
Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2570923002
==========

to

==========
Makes AudioOutputDispatcher non-ref-counted.

AudioManagerBase owns AudioOutputDispatcher instances. AudioOutputProxy
no longer holds a strong reference to AudioOutputDispatcher. This means
dispatcher instances will be deleted when AudioManager shuts down and
fire CHECKs for any open proxy streams.

BUG=608049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1873f1437ee75eeca154753660b33ff2336509f0
Cr-Commit-Position: refs/heads/master@{#438285}
==========

[commit-bot: I haz the power, 2016-12-13 21:43:39]

Patchset 1 (id:??) landed as
https://crrev.com/1873f1437ee75eeca154753660b33ff2336509f0
Cr-Commit-Position: refs/heads/master@{#438285}