Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: media/audio/audio_output_proxy_unittest.cc

Issue 2570923002: Makes AudioOutputDispatcher non-ref-counted. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_proxy_unittest.cc
diff --git a/media/audio/audio_output_proxy_unittest.cc b/media/audio/audio_output_proxy_unittest.cc
index 37e012a62b4e662733d06e885872dd20fbbd388e..9900eb18341f9acd04b45002a370d8815f7b0b44 100644
--- a/media/audio/audio_output_proxy_unittest.cc
+++ b/media/audio/audio_output_proxy_unittest.cc
@@ -7,6 +7,7 @@
#include <memory>
#include <string>
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
@@ -174,10 +175,8 @@ class AudioOutputProxyTest : public testing::Test {
}
virtual void InitDispatcher(base::TimeDelta close_delay) {
- dispatcher_impl_ = new AudioOutputDispatcherImpl(&manager(),
- params_,
- std::string(),
- close_delay);
+ dispatcher_impl_ = base::MakeUnique<AudioOutputDispatcherImpl>(
+ &manager(), params_, std::string(), close_delay);
}
virtual void OnStart() {}
@@ -422,7 +421,7 @@ class AudioOutputProxyTest : public testing::Test {
}
base::MessageLoop message_loop_;
- scoped_refptr<AudioOutputDispatcherImpl> dispatcher_impl_;
+ std::unique_ptr<AudioOutputDispatcherImpl> dispatcher_impl_;
MockAudioManager manager_;
MockAudioSourceCallback callback_;
AudioParameters params_;
@@ -439,7 +438,7 @@ class AudioOutputResamplerTest : public AudioOutputProxyTest {
resampler_params_ = AudioParameters(
AudioParameters::AUDIO_PCM_LOW_LATENCY, CHANNEL_LAYOUT_STEREO,
16000, 16, 1024);
- resampler_ = new AudioOutputResampler(
+ resampler_ = base::MakeUnique<AudioOutputResampler>(
&manager(), params_, resampler_params_, std::string(), close_delay);
}
@@ -454,7 +453,7 @@ class AudioOutputResamplerTest : public AudioOutputProxyTest {
protected:
AudioParameters resampler_params_;
- scoped_refptr<AudioOutputResampler> resampler_;
+ std::unique_ptr<AudioOutputResampler> resampler_;
};
TEST_F(AudioOutputProxyTest, CreateAndClose) {

Powered by Google App Engine
This is Rietveld 408576698