Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: media/audio/audio_output_dispatcher_impl.h

Issue 2570923002: Makes AudioOutputDispatcher non-ref-counted. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_dispatcher_impl.h
diff --git a/media/audio/audio_output_dispatcher_impl.h b/media/audio/audio_output_dispatcher_impl.h
index 0923319fab88f324afa0944bf180476d20b4aa87..97eb46bce0cbbc673639020d004092218b3de313 100644
--- a/media/audio/audio_output_dispatcher_impl.h
+++ b/media/audio/audio_output_dispatcher_impl.h
@@ -40,6 +40,7 @@ class MEDIA_EXPORT AudioOutputDispatcherImpl : public AudioOutputDispatcher {
const AudioParameters& params,
const std::string& output_device_id,
const base::TimeDelta& close_delay);
+ ~AudioOutputDispatcherImpl() override;
// Opens a new physical stream if there are no pending streams in
// |idle_streams_|. Do not call Close() or Stop() if this method fails.
@@ -61,8 +62,6 @@ class MEDIA_EXPORT AudioOutputDispatcherImpl : public AudioOutputDispatcher {
// kept alive until |close_timer_| fires.
void CloseStream(AudioOutputProxy* stream_proxy) override;
- void Shutdown() override;
-
// Returns true if there are any open AudioOutputProxy objects.
bool HasOutputProxies() const;
@@ -70,9 +69,6 @@ class MEDIA_EXPORT AudioOutputDispatcherImpl : public AudioOutputDispatcher {
void CloseAllIdleStreams();
private:
- friend class base::RefCountedThreadSafe<AudioOutputDispatcherImpl>;
- ~AudioOutputDispatcherImpl() override;
-
// Creates a new physical output stream, opens it and pushes to
// |idle_streams_|. Returns false if the stream couldn't be created or
// opened.

Powered by Google App Engine
This is Rietveld 408576698