Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2570873002: Revert of Implement a runtime headless mode for Linux (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, nona+watch_chromium.org, piman+watch_chromium.org, sadrul, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement a runtime headless mode for Linux (patchset #20 id:380001 of https://codereview.chromium.org/1991953002/ ) Reason for revert: Unexpectedly added a couple of new static initializers: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/29946 Original issue's description: > Implement a runtime headless mode for Linux > > This patch implements a runtime headless mode (i.e., a > --headless command line switch) that makes it possible to > use a regular Chrome binary as a headless. When the binary > is launched with this switch, the main entrypoint calls > into the Headless Shell entrypoint, effectively starting > that shell instead of Chrome. > > To make this possible we must remove the dependency from > Headless to Ozone, because Ozone is a build-time feature > which is generally not enabled for regular Chrome builds. > In practice this means implementing a new headless-specific > WindowTreeHost and modifying various graphics and input > entrypoints to do something appropriate in headless mode. > > Since many of the modifications are in platform-specific > code, this initial patch only adds headless support in Linux. > Other platforms will be added later. > > Design doc: https://docs.google.com/document/d/1aIJUzQr3eougZQp90bp4mqGr5gY6hdUice8UPa-Ys90/edit# > > BUG=612904 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/eb0f3b0218478f30858dfa2078cb350ea259701f > Cr-Commit-Position: refs/heads/master@{#438152} TBR=jochen@chromium.org,eseckler@chromium.org,sky@chromium.org,zmo@chromium.org,vmiura@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612904 Committed: https://crrev.com/afc6f8a4091a7469c47145cba537daa3cfb456e0 Cr-Commit-Position: refs/heads/master@{#438177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -278 lines) Patch
M chrome/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +1 line, -5 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/zygote_host/zygote_communication_linux.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +22 lines, -27 lines 0 comments Download
M gpu/ipc/service/gpu_init.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M headless/BUILD.gn View 4 chunks +8 lines, -9 lines 0 comments Download
M headless/DEPS View 1 chunk +1 line, -6 lines 0 comments Download
M headless/README.md View 1 chunk +0 lines, -1 line 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
D headless/lib/browser/headless_platform_event_source.h View 1 chunk +0 lines, -26 lines 0 comments Download
D headless/lib/browser/headless_platform_event_source.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
D headless/lib/browser/headless_window_tree_host.h View 1 chunk +0 lines, -48 lines 0 comments Download
D headless/lib/browser/headless_window_tree_host.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M headless/lib/headless_content_main_delegate.h View 3 chunks +6 lines, -2 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 3 chunks +14 lines, -7 lines 0 comments Download
A headless/lib/renderer/headless_content_renderer_client.h View 1 chunk +22 lines, -0 lines 0 comments Download
A headless/lib/renderer/headless_content_renderer_client.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A headless/lib/utility/headless_content_utility_client.h View 1 chunk +22 lines, -0 lines 0 comments Download
A headless/lib/utility/headless_content_utility_client.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/icc_profile_x11.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/gfx/switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/init/gl_initializer_x11.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sami
Created Revert of Implement a runtime headless mode for Linux
4 years ago (2016-12-13 15:47:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570873002/1
4 years ago (2016-12-13 15:48:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 15:49:44 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 15:52:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afc6f8a4091a7469c47145cba537daa3cfb456e0
Cr-Commit-Position: refs/heads/master@{#438177}

Powered by Google App Engine
This is Rietveld 408576698