Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2570783006: DevTools: convert a few more icons to UI.Icon. (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: convert a few more icons to UI.Icon. This patch migrates a few more instances of icons onto UI.Icon: - console's expand stack trace triangle - styles sidebar pane's expand triangle for longhands - blockedURL's "remove" button BUG=669323 R=dgozman Committed: https://crrev.com/d2b33e185dd8325dd9bd7c643a466826664f076d Cr-Commit-Position: refs/heads/master@{#438646}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 14 (8 generated)
lushnikov
please, take a look
4 years ago (2016-12-14 19:05:15 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2570783006/diff/1/third_party/WebKit/Source/devtools/front_end/console/consoleView.css File third_party/WebKit/Source/devtools/front_end/console/consoleView.css (right): https://codereview.chromium.org/2570783006/diff/1/third_party/WebKit/Source/devtools/front_end/console/consoleView.css#newcode371 third_party/WebKit/Source/devtools/front_end/console/consoleView.css:371: background-color: rgb(110, 110, 110); Can we make this ...
4 years ago (2016-12-14 19:18:25 UTC) #4
lushnikov
https://codereview.chromium.org/2570783006/diff/1/third_party/WebKit/Source/devtools/front_end/console/consoleView.css File third_party/WebKit/Source/devtools/front_end/console/consoleView.css (right): https://codereview.chromium.org/2570783006/diff/1/third_party/WebKit/Source/devtools/front_end/console/consoleView.css#newcode371 third_party/WebKit/Source/devtools/front_end/console/consoleView.css:371: background-color: rgb(110, 110, 110); On 2016/12/14 19:18:25, dgozman wrote: ...
4 years ago (2016-12-14 22:02:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570783006/1
4 years ago (2016-12-14 22:03:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 22:08:04 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 22:09:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2b33e185dd8325dd9bd7c643a466826664f076d
Cr-Commit-Position: refs/heads/master@{#438646}

Powered by Google App Engine
This is Rietveld 408576698