Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2572283002: DevTools: set a default color for icon masks (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: set a default color for icon masks This patch sets a default color for icon masks. This should be good enough to solve concerns in https://crrev.com/2570783006 while supporting dark theme. BUG=669323 R=dgozman Committed: https://crrev.com/f212359e033d6e1912146753fe23715d13760a22 Cr-Commit-Position: refs/heads/master@{#438761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
lushnikov
please, take a look
4 years ago (2016-12-15 00:26:17 UTC) #3
dgozman
lgtm
4 years ago (2016-12-15 03:09:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572283002/1
4 years ago (2016-12-15 05:44:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 05:53:39 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 05:59:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f212359e033d6e1912146753fe23715d13760a22
Cr-Commit-Position: refs/heads/master@{#438761}

Powered by Google App Engine
This is Rietveld 408576698