Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 2570633004: DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params. (Closed)
Patch Set: review comments addressed Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
index 6ea762162960432d3759b80151860f0b4099fcaf..9a758c29ac180672af79659209679296abfe6b62 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
@@ -95,9 +95,13 @@ UI.FilterBar = class extends UI.HBox {
}
_updateFilterBar() {
+ if (!this.parentWidget())
+ return;
var visible = this._alwaysShowFilters || (this._filtersShown && this._enabled);
- this.element.classList.toggle('hidden', !visible);
- this.invalidateSize();
+ if (visible)
+ this.showWidget();
+ else
+ this.hideWidget();
}
_focusTextField() {

Powered by Google App Engine
This is Rietveld 408576698