Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

Issue 2570633004: DevTools: remove invalidateSize from Widget, make show/hideWidget receive no params. (Closed)
Patch Set: review comments addressed Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
index 9140d9215500c8e9b9aee7305e8c9028eded82b1..0f92ea648a4d27472bbe3771b02116f79767bd7e 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
@@ -142,7 +142,7 @@ UI.SplitWidget = class extends UI.Widget {
widget.element.classList.remove('insertion-point-sidebar');
widget.attach(this);
if (this._showMode === UI.SplitWidget.ShowMode.OnlyMain || this._showMode === UI.SplitWidget.ShowMode.Both)
- widget.showWidget(this.element);
+ widget.showWidget();
}
this.resumeInvalidations();
}
@@ -162,7 +162,7 @@ UI.SplitWidget = class extends UI.Widget {
widget.element.classList.remove('insertion-point-main');
widget.attach(this);
if (this._showMode === UI.SplitWidget.ShowMode.OnlySidebar || this._showMode === UI.SplitWidget.ShowMode.Both)
- widget.showWidget(this.element);
+ widget.showWidget();
}
this.resumeInvalidations();
}
@@ -283,9 +283,9 @@ UI.SplitWidget = class extends UI.Widget {
if (sideToShow) {
// Make sure main is first in the children list.
if (sideToShow === this._mainWidget)
- this._mainWidget.showWidget(this.element);
+ this._mainWidget.showWidget();
else
- this._sidebarWidget.showWidget(this.element);
+ this._sidebarWidget.showWidget();
}
if (sideToHide)
sideToHide.hideWidget();
@@ -343,9 +343,9 @@ UI.SplitWidget = class extends UI.Widget {
// Make sure main is the first in the children list.
this.suspendInvalidations();
if (this._sidebarWidget)
- this._sidebarWidget.showWidget(this.element);
+ this._sidebarWidget.showWidget();
if (this._mainWidget)
- this._mainWidget.showWidget(this.element);
+ this._mainWidget.showWidget();
this.resumeInvalidations();
// Order widgets in DOM properly.
this.setSecondIsSidebar(this._secondIsSidebar);

Powered by Google App Engine
This is Rietveld 408576698