Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2570463005: Retire ThreadState::registerPreFinalizer<T>() (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, shans, tzik, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, scheib+watch_chromium.org, apavlov+blink_chromium.org, Mads Ager (chromium), Srirama, kouhei+svg_chromium.org, kinuko+watch, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, krit, awdf+watch_chromium.org, toyoshim+midi_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, kinuko+serviceworker, Justin Novosad, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, feature-vr-reviews_chromium.org, blink-reviews, gyuyoung2, falken+watch_chromium.org, loading-reviews_chromium.org, pdr+svgwatchlist_chromium.org, mcasas+watch+mediastream_chromium.org, Eric Willigers, nessy, rjwright, blink-reviews-style_chromium.org, serviceworker-reviews, Peter Beverloo, sof, nhiroki, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, vcarbune.chromium, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, horo+watch_chromium.org, gasubic, loading-reviews+parser_chromium.org, ajuma+watch-canvas_chromium.org, f(malita), mac-reviews_chromium.org, oilpan-reviews, ortuno+watch_chromium.org, Stephen Chennney, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire ThreadState::registerPreFinalizer<T>() The registration of the finalization callback now happens under-the-hood and automatically. R=haraken BUG=673645 Committed: https://crrev.com/9a49b977d6609b49e78e50f4b1efce71739c80ff Cr-Commit-Position: refs/heads/master@{#438136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MockResourceClient.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceOwner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
sof
please take a look. big footprint, sorry, but uniform.
4 years ago (2016-12-13 10:09:44 UTC) #5
haraken
LGTM
4 years ago (2016-12-13 11:54:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570463005/1
4 years ago (2016-12-13 12:00:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 12:07:48 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 12:12:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a49b977d6609b49e78e50f4b1efce71739c80ff
Cr-Commit-Position: refs/heads/master@{#438136}

Powered by Google App Engine
This is Rietveld 408576698