third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp - Issue 2570463005: Retire ThreadState::registerPreFinalizer<T>()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

Issue 2570463005: Retire ThreadState::registerPreFinalizer<T>() (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

index 7653df1fa8c4d87f9ca2cbb81227c3c4e7878e0a..33ec9d0d358c2e9aaa73dd5f05324ccc13f94d82 100644

--- a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

+++ b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

@@ -16,7 +16,6 @@ PromiseRejectionEvent::PromiseRejectionEvent(

m_world(state->world()),

m_promise(this),

m_reason(this) {

- ThreadState::current()->registerPreFinalizer(this);

DCHECK(initializer.hasPromise());

m_promise.set(initializer.promise().isolate(),

initializer.promise().v8Value());