third_party/WebKit/Source/modules/webusb/USB.cpp - Issue 2570463005: Retire ThreadState::registerPreFinalizer<T>()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USB.cpp

Issue 2570463005: Retire ThreadState::registerPreFinalizer<T>() (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/USB.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USB.cpp b/third_party/WebKit/Source/modules/webusb/USB.cpp

index 9e8252c305dd3b8284247cd7cb2f767843f4055e..d3f179b5c361ecfa7299d96e27db1b255b19971d 100644

--- a/third_party/WebKit/Source/modules/webusb/USB.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USB.cpp

@@ -53,7 +53,6 @@ usb::DeviceFilterPtr convertDeviceFilter(const USBDeviceFilter& filter) {

USB::USB(LocalFrame& frame)

: ContextLifecycleObserver(frame.document()), m_clientBinding(this) {

- ThreadState::current()->registerPreFinalizer(this);

frame.interfaceProvider()->getInterface(mojo::GetProxy(&m_deviceManager));

m_deviceManager.set_connection_error_handler(convertToBaseCallback(WTF::bind(

&USB::onDeviceManagerConnectionError, wrapWeakPersistent(this))));