[SPInvalidation] Update paint properties on css clip change

[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1ea99b023ae5c0d7a421b2e308fa910aa6bd107c
Cr-Commit-Position: refs/heads/master@{#438068}

[Xianzhu, 2016-12-12 20:54:41]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 20:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-12 20:59:47]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-12-12 20:59:48]

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.h:805: DCHECK(!result ||
isOutOfFlowPositioned());
During style recalc, inapplicable clip properties are removed, so we can only
see clip property for out-of-flow-positioned objects. This is ensured by two new
tests static-to-absolute-clip-change.html and
absolute-to-static-clip-change.html.

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:934: return
m_visual.get() != other.m_visual.get() &&
During style recalc, inapplicable clip properties are removed, so we can only
see clip property for out-of-flow-positioned objects and don't need to check
position here. Also the previous check "!= StaticPosition" was incorrect.
Should have checked hasOutOfFlowPosition() instead because clip doesn't apply
to relative position.

[pdr., 2016-12-12 21:13:25]

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1726:
setNeedsPaintPropertyUpdate();
This seems like over-invalidation. Previously we only did this when specific
properties changed (e.g., opacity, etc), but now you're doing it on all setStyle
calls.

Did you forget to call diffNeedsPaintPropertyUpdate() here?

[Xianzhu, 2016-12-12 21:42:05]

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1726:
setNeedsPaintPropertyUpdate();
On 2016/12/12 21:13:25, pdr. wrote:
> This seems like over-invalidation. Previously we only did this when specific
> properties changed (e.g., opacity, etc), but now you're doing it on all
setStyle
> calls.
> 
> Did you forget to call diffNeedsPaintPropertyUpdate() here?

Oh, right. Was surprised why this CL magically fixed a transform property
under-invalidation. Fixing.

[Xianzhu, 2016-12-12 23:09:55]

Description was changed from

==========
Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
==========

to

==========
Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-12 23:09:56]

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1726:
setNeedsPaintPropertyUpdate();
On 2016/12/12 21:42:05, Xianzhu wrote:
> On 2016/12/12 21:13:25, pdr. wrote:
> > This seems like over-invalidation. Previously we only did this when specific
> > properties changed (e.g., opacity, etc), but now you're doing it on all
> setStyle
> > calls.
> > 
> > Did you forget to call diffNeedsPaintPropertyUpdate() here?
> 
> Oh, right. Was surprised why this CL magically fixed a transform property
> under-invalidation. Fixing.

Done.

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.h:805: DCHECK(!result ||
isOutOfFlowPositioned());
On 2016/12/12 20:59:47, Xianzhu wrote:
> During style recalc, inapplicable clip properties are removed, so we can only
> see clip property for out-of-flow-positioned objects. This is ensured by two
new
> tests static-to-absolute-clip-change.html and
> absolute-to-static-clip-change.html.

This is incorrect. Please ignore it.

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2570463004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:934: return
m_visual.get() != other.m_visual.get() &&
On 2016/12/12 20:59:47, Xianzhu wrote:
> During style recalc, inapplicable clip properties are removed, so we can only
> see clip property for out-of-flow-positioned objects and don't need to check
> position here. Also the previous check "!= StaticPosition" was incorrect.
> Should have checked hasOutOfFlowPosition() instead because clip doesn't apply
> to relative position.

This is incorrect. Please ignore it.

[Xianzhu, 2016-12-12 23:09:57]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 23:11:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-12 23:36:49]

Description was changed from

==========
Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
==========

to

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
==========

[commit-bot: I haz the power, 2016-12-12 23:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:38:32]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-12-12 23:44:22]

LGTM

https://codereview.chromium.org/2570463004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
(right):

https://codereview.chromium.org/2570463004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:3141: // A
basic sanity check for over-invalidation of paint properties.
+1, thanks

[Xianzhu, 2016-12-12 23:46:43]

Description was changed from

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
==========

to

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-12 23:46:44]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-12 23:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2570463004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-12 23:47:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-12 23:49:41]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-12 23:49:51]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:51:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:47:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-13 01:49:58]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:51:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 03:29:46]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:98
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
69cfd094e3ed3049ea27f0d0410b7a41d8b86f3b..f0235354ea4a7677383cdc5c0f7ba4acc7d68abb
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -98,14 +98,11 @@ crbug.com/626748
virtual/spinvalidation/paint/invalidation/table/cached-change-t
 crbug.com/646176 virtual/spinvalidation/ [ Skip ]
 crbug.com/646176 virtual/spinvalidation/paint/invalidation/ [ Pass ]
 
-crbug.com/645667
virtual/spinvalidation/paint/invalidation/outline-clip-change.html [ Crash
Failure ]
 crbug.com/645667
virtual/spinvalidation/paint/invalidation/filter-repaint-accelerated-on-accelerated-filter.html
[ Crash ]
 crbug.com/645667
virtual/spinvalidation/paint/invalidation/position-change-keeping-geometry.html
[ Crash ]
 crbug.com/645667
virtual/spinvalidation/paint/invalidation/svg/marker-viewBox-changes.svg [ Crash
Failure ]
-crbug.com/645667
virtual/spinvalidation/paint/invalidation/compositing/should-not-repaint-composited-descendants.html
[ Crash ]
 crbug.com/645667
virtual/spinvalidation/paint/invalidation/compositing/resize-repaint.html [
Crash ]
 crbug.com/645667
virtual/spinvalidation/paint/invalidation/compositing/shrink-layer.html [ Crash
]
-crbug.com/645667
virtual/spinvalidation/paint/invalidation/compositing/clipping-should-not-repaint-composited-descendants.html
[ Crash ]
 crbug.com/645667
virtual/spinvalidation/paint/invalidation/filter-repaint-on-accelerated-layer.html
[ Crash ]
 
 # --- End SlimmingPaintInvalidation Tests ---

[Xianzhu, 2016-12-13 03:51:09]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-13 03:51:09]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2570463004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-13 03:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 05:44:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481601069052500,
"parent_rev": "dd0cb99b71d228416a575dd2b35bad83f4a34110", "commit_rev":
"092a280d5b7b32035b74f5d4d02fe1dca045eccd"}

[commit-bot: I haz the power, 2016-12-13 05:44:36]

Description was changed from

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2570463004
==========

[commit-bot: I haz the power, 2016-12-13 05:44:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 05:46:39]

Description was changed from

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2570463004
==========

to

==========
[SPInvalidation] Update paint properties on css clip change

Add StyleDifference::needsPaintPropertyUpdate() to indicate a style
change directly needs paint property update, and set the flag on
changes of css clip, transform, etc.

Move two tests from their original directory into paint/invalidation.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1ea99b023ae5c0d7a421b2e308fa910aa6bd107c
Cr-Commit-Position: refs/heads/master@{#438068}
==========

[commit-bot: I haz the power, 2016-12-13 05:46:40]

Patchset 4 (id:??) landed as
https://crrev.com/1ea99b023ae5c0d7a421b2e308fa910aa6bd107c
Cr-Commit-Position: refs/heads/master@{#438068}