Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2570463004: [SPInvalidation] Update paint properties on css clip change (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index a83f2f2f56f4c9d035a0d680131a294630494cf4..f3b61ccc79fd92c1629bc6092fac0c58c7175006 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -594,8 +594,12 @@ StyleDifference ComputedStyle::visualInvalidationDiff(
updatePropertySpecificDifferences(other, diff);
+ // The following conditions need to be at last, because they may depend on
+ // conditions in diff computed above.
if (scrollAnchorDisablingPropertyChanged(other, diff))
diff.setScrollAnchorDisablingPropertyChanged();
+ if (diffNeedsPaintPropertyUpdate(other, diff))
+ diff.setNeedsPaintPropertyUpdate();
// Cursors are not checked, since they will be set appropriately in response
// to mouse events, so they don't need to cause any paint invalidation or
@@ -610,7 +614,7 @@ StyleDifference ComputedStyle::visualInvalidationDiff(
bool ComputedStyle::scrollAnchorDisablingPropertyChanged(
const ComputedStyle& other,
- StyleDifference& diff) const {
+ const StyleDifference& diff) const {
if (m_nonInheritedData.m_position != other.m_nonInheritedData.m_position)
return true;
@@ -932,11 +936,6 @@ bool ComputedStyle::diffNeedsFullLayout(const ComputedStyle& other) const {
bool ComputedStyle::diffNeedsPaintInvalidationSubtree(
const ComputedStyle& other) const {
- if (position() != StaticPosition &&
- (m_visual->clip != other.m_visual->clip ||
- m_visual->hasAutoClip != other.m_visual->hasAutoClip))
- return true;
-
if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()) {
if (m_rareNonInheritedData->m_effectiveBlendMode !=
other.m_rareNonInheritedData->m_effectiveBlendMode ||
@@ -1132,6 +1131,24 @@ void ComputedStyle::updatePropertySpecificDifferences(
diff.setTextDecorationOrColorChanged();
}
}
+
+ bool hasClip = hasOutOfFlowPosition() && !m_visual->hasAutoClip;
+ bool otherHasClip =
+ other.hasOutOfFlowPosition() && !other.m_visual->hasAutoClip;
+ if (hasClip != otherHasClip ||
+ (hasClip && m_visual->clip != other.m_visual->clip))
+ diff.setCSSClipChanged();
+}
+
+bool ComputedStyle::diffNeedsPaintPropertyUpdate(
+ const ComputedStyle& other,
+ const StyleDifference& diff) const {
+ if (diff.transformChanged() || diff.opacityChanged() ||
+ diff.zIndexChanged() || diff.filterChanged() ||
+ diff.backdropFilterChanged() || diff.cssClipChanged())
+ return true;
+
+ return false;
}
void ComputedStyle::addPaintImage(StyleImage* image) {
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/StyleDifference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698