This CL removes some of the unused CFWL widget flags.

This CL removes some of the unused CFWL widget flags.

Several of the widgets have flags which are no longer set. This CL
removes the flags and any flag conditional code.

Review-Url: https://codereview.chromium.org/2570083002
Committed: https://pdfium.googlesource.com/pdfium/+/727a304f2ab5b72846186af0e75e6c047de0a13c

[dsinclair, 2016-12-13 16:41:56]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:42:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-13 16:42:06]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-13 16:42:07]

PTAL.

https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_checkbox.cpp
File xfa/fwl/cfwl_checkbox.cpp (left):

https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_checkbox.cpp#o...
xfa/fwl/cfwl_checkbox.cpp:225: case FWL_STYLEEXT_CKB_Left |
FWL_STYLEEXT_CKB_Top: {
_Left and _Top are both 0, so if there are no matching styles then the switch
condition should be 0 and match this.

[commit-bot: I haz the power, 2016-12-13 16:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:54:33]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-13 17:34:31]

https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_combobox.h
File xfa/fwl/cfwl_combobox.h (left):

https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_combobox.h#old...
xfa/fwl/cfwl_combobox.h:31: #define FWL_STYLEEXT_CMB_EditHNear (0L << 4)
probably want to introduce a "mask" constant like line 41 for documentation and
keep these ...

[dsinclair, 2016-12-13 18:56:55]

https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_combobox.h
File xfa/fwl/cfwl_combobox.h (left):

https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_combobox.h#old...
xfa/fwl/cfwl_combobox.h:31: #define FWL_STYLEEXT_CMB_EditHNear (0L << 4)
On 2016/12/13 17:34:31, Tom Sepez wrote:
> probably want to introduce a "mask" constant like line 41 for documentation
and
> keep these ...

Keep which, the 0<< 4 or EditHFar? I'm not sure if the mask comment would help
as they won't be used.

[Tom Sepez, 2016-12-13 19:31:42]

On 2016/12/13 18:56:55, dsinclair wrote:
> https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_combobox.h
> File xfa/fwl/cfwl_combobox.h (left):
> 
>
https://codereview.chromium.org/2570083002/diff/1/xfa/fwl/cfwl_combobox.h#old...
> xfa/fwl/cfwl_combobox.h:31: #define FWL_STYLEEXT_CMB_EditHNear (0L << 4)
> On 2016/12/13 17:34:31, Tom Sepez wrote:
> > probably want to introduce a "mask" constant like line 41 for documentation
> and
> > keep these ...
> 
> Keep which, the 0<< 4 or EditHFar? I'm not sure if the mask comment would help
> as they won't be used.
Ok, As you like.

Also CL description should say "flags" not "lags".

[Tom Sepez, 2016-12-13 19:32:09]

lgtm otherwise

[dsinclair, 2016-12-14 14:43:57]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 14:44:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 14:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 14:53:53]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-14 14:55:54]

Description was changed from

==========
This CL removes some of the unused CFWL widget lags.

Sevearl of the widgets have flags which are no longer set. This CL removes the
flags and any flag conditional code.
==========

to

==========
This CL removes some of the unused CFWL widget flags.

Sevearl of the widgets have flags which are no longer set. This CL removes the
flags and any flag conditional code.
==========

[dsinclair, 2016-12-14 14:56:06]

Description was changed from

==========
This CL removes some of the unused CFWL widget flags.

Sevearl of the widgets have flags which are no longer set. This CL removes the
flags and any flag conditional code.
==========

to

==========
This CL removes some of the unused CFWL widget flags.

Several of the widgets have flags which are no longer set. This CL
removes the flags and any flag conditional code.
==========

[dsinclair, 2016-12-14 20:55:50]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-14 20:55:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2570083002/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-12-14 20:55:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:07:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481748950711760,
"parent_rev": "be5f0297256ba3c597dd32eb7eefef57fbd8e201", "commit_rev":
"727a304f2ab5b72846186af0e75e6c047de0a13c"}

[commit-bot: I haz the power, 2016-12-14 21:07:50]

Description was changed from

==========
This CL removes some of the unused CFWL widget flags.

Several of the widgets have flags which are no longer set. This CL
removes the flags and any flag conditional code.
==========

to

==========
This CL removes some of the unused CFWL widget flags.

Several of the widgets have flags which are no longer set. This CL
removes the flags and any flag conditional code.

Review-Url: https://codereview.chromium.org/2570083002
Committed:
https://pdfium.googlesource.com/pdfium/+/727a304f2ab5b72846186af0e75e6c047de0...
==========

[commit-bot: I haz the power, 2016-12-14 21:07:51]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/727a304f2ab5b72846186af0e75e6c047de0...