Remove unused CFWL_ListBox code

Remove unused CFWL_ListBox code

This CL removes states and settings from the CFWL_ListBox code which were never
enabled.

Review-Url: https://codereview.chromium.org/2576483002
Committed: https://pdfium.googlesource.com/pdfium/+/be5f0297256ba3c597dd32eb7eefef57fbd8e201

[dsinclair, 2016-12-13 15:19:41]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-13 15:19:42]

PTAL.

[dsinclair, 2016-12-13 15:19:45]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 15:19:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 15:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 15:29:37]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-13 17:32:03]

https://codereview.chromium.org/2576483002/diff/1/xfa/fwl/cfwl_combobox.h
File xfa/fwl/cfwl_combobox.h (left):

https://codereview.chromium.org/2576483002/diff/1/xfa/fwl/cfwl_combobox.h#old...
xfa/fwl/cfwl_combobox.h:47: #define FWL_STYLEEXT_CMB_ListItemIconText (1L << 12)
Can we keep this one and lose the prior and invert the math later on?

[dsinclair, 2016-12-13 18:57:59]

https://codereview.chromium.org/2576483002/diff/1/xfa/fwl/cfwl_combobox.h
File xfa/fwl/cfwl_combobox.h (left):

https://codereview.chromium.org/2576483002/diff/1/xfa/fwl/cfwl_combobox.h#old...
xfa/fwl/cfwl_combobox.h:47: #define FWL_STYLEEXT_CMB_ListItemIconText (1L << 12)
On 2016/12/13 17:32:03, Tom Sepez wrote:
> Can we keep this one and lose the prior and invert the math later on?

Not sure what you mean. You want to keep ListItemIconText or the value of 1<<12?
Keeping the 1<<12 could be more difficult as, currently, if style is empty it
will be ItemText, if we give the ItemText a value of 1 then a default empty
style will no longer be text .....

[dsinclair, 2016-12-14 14:26:32]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 14:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 14:36:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 14:36:47]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-14 16:16:54]

On 2016/12/13 18:57:59, dsinclair wrote:
> https://codereview.chromium.org/2576483002/diff/1/xfa/fwl/cfwl_combobox.h
> File xfa/fwl/cfwl_combobox.h (left):
> 
>
https://codereview.chromium.org/2576483002/diff/1/xfa/fwl/cfwl_combobox.h#old...
> xfa/fwl/cfwl_combobox.h:47: #define FWL_STYLEEXT_CMB_ListItemIconText (1L <<
12)
> On 2016/12/13 17:32:03, Tom Sepez wrote:
> > Can we keep this one and lose the prior and invert the math later on?
> 
> Not sure what you mean. You want to keep ListItemIconText or the value of
1<<12?
> Keeping the 1<<12 could be more difficult as, currently, if style is empty it
> will be ItemText, if we give the ItemText a value of 1 then a default empty
> style will no longer be text .....


ping

[Tom Sepez, 2016-12-14 17:20:16]

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_combobox.h
File xfa/fwl/cfwl_combobox.h (right):

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_combobox.h...
xfa/fwl/cfwl_combobox.h:46: #define FWL_STYLEEXT_CMB_ListItemText (0L << 12)
this one is unused, too?

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listbox.cpp
File xfa/fwl/cfwl_listbox.cpp (right):

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listbox.cp...
xfa/fwl/cfwl_listbox.cpp:519: if (!bShowVertScr && m_pProperties->m_dwStyles &
FWL_WGTSTYLE_VScroll)
nit: add () around the bitwise expression (m_Properties .... Scroll) just to
emphasize that it's not a mistake where you meant &&

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listitem.cpp
File xfa/fwl/cfwl_listitem.cpp (right):

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listitem.c...
xfa/fwl/cfwl_listitem.cpp:11: m_rtItem.Reset();
does this do anything?

[dsinclair, 2016-12-14 17:43:55]

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_combobox.h
File xfa/fwl/cfwl_combobox.h (right):

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_combobox.h...
xfa/fwl/cfwl_combobox.h:46: #define FWL_STYLEEXT_CMB_ListItemText (0L << 12)
On 2016/12/14 17:20:16, Tom Sepez wrote:
> this one is unused, too?

Removed in later CL.

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listbox.cpp
File xfa/fwl/cfwl_listbox.cpp (right):

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listbox.cp...
xfa/fwl/cfwl_listbox.cpp:519: if (!bShowVertScr && m_pProperties->m_dwStyles &
FWL_WGTSTYLE_VScroll)
On 2016/12/14 17:20:16, Tom Sepez wrote:
> nit: add () around the bitwise expression (m_Properties .... Scroll) just to
> emphasize that it's not a mistake where you meant &&

Done.

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listitem.cpp
File xfa/fwl/cfwl_listitem.cpp (right):

https://codereview.chromium.org/2576483002/diff/40001/xfa/fwl/cfwl_listitem.c...
xfa/fwl/cfwl_listitem.cpp:11: m_rtItem.Reset();
On 2016/12/14 17:20:16, Tom Sepez wrote:
> does this do anything?

Sadly, yes. CFX_RectF has no constructor, so the only way to initialize top,
right, bottom, left is through Reset ....

[Tom Sepez, 2016-12-14 20:38:31]

lgtm

[dsinclair, 2016-12-14 20:43:29]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:43:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:54:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481748209591760,
"parent_rev": "f085db37c21ad2bd66e349f9307fc89b426217f5", "commit_rev":
"be5f0297256ba3c597dd32eb7eefef57fbd8e201"}

[commit-bot: I haz the power, 2016-12-14 20:54:32]

Description was changed from

==========
Remove unused CFWL_ListBox code

This CL removes states and settings from the CFWL_ListBox code which were never
enabled.
==========

to

==========
Remove unused CFWL_ListBox code

This CL removes states and settings from the CFWL_ListBox code which were never
enabled.

Review-Url: https://codereview.chromium.org/2576483002
Committed:
https://pdfium.googlesource.com/pdfium/+/be5f0297256ba3c597dd32eb7eefef57fbd8...
==========

[commit-bot: I haz the power, 2016-12-14 20:54:33]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/be5f0297256ba3c597dd32eb7eefef57fbd8...