Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2570033003: Remove unused CFWL_Edit flags. (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused CFWL_Edit flags. This CL removes the flags from CFWL_Edit which are never set. In turn, the coresponding text edit engine flags are removed. Review-Url: https://codereview.chromium.org/2570033003 Committed: https://pdfium.googlesource.com/pdfium/+/aefbe4b52d8f309dbb2d8655d936d4a4b443c76e

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Fix windows compile error #

Patch Set 4 : Rebase to master #

Patch Set 5 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -316 lines) Patch
M xfa/fde/cfde_txtedtengine.cpp View 1 2 3 11 chunks +80 lines, -214 lines 0 comments Download
M xfa/fde/cfde_txtedtpage.cpp View 1 2 3 5 chunks +14 lines, -35 lines 0 comments Download
M xfa/fde/ifde_txtedtengine.h View 1 chunk +1 line, -12 lines 0 comments Download
M xfa/fwl/cfwl_edit.h View 1 chunk +2 lines, -11 lines 0 comments Download
M xfa/fwl/cfwl_edit.cpp View 1 2 7 chunks +13 lines, -43 lines 0 comments Download
M xfa/fwl/fwl_widgetdef.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
dsinclair
PTAL.
4 years ago (2016-12-13 18:20:49 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-13 19:05:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570033003/80001
4 years ago (2016-12-14 21:08:22 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 21:21:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/aefbe4b52d8f309dbb2d8655d936d4a4b443...

Powered by Google App Engine
This is Rietveld 408576698