Low risk non-nullable => nullable change

Low risk non-nullable => nullable change

Made the following arguments / attributes nullable to match the spec.

BUG=662005
Committed: https://crrev.com/8734aac57d4f724768a53326542d911f1836ad45
Cr-Commit-Position: refs/heads/master@{#438498}

[lunalu1, 2016-12-13 22:17:49]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 22:19:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:34:22]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[foolip, 2016-12-13 22:37:31]

foolip@chromium.org changed reviewers:
+ foolip@chromium.org

[foolip, 2016-12-13 22:37:31]

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLInputElement.idl (right):

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLInputElement.idl:83: [RaisesException,
ImplementedAs=selectionStartForBinding] attribute long? selectionStart;
OK, so I said that making readonly attributes nullable doesn't change the
generated code, but it's not always true. For things like WTF::String and
pointers that can be null, it just works, but for integers etc. an extra
argument is added to the getter, which is why the compile is now failing.

I'd exclude this change, because it would also need to actually return null in
some situation for it to be useful, which then requires tests and so on.

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.idl
(right):

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.idl:31:
// https://html.spec.whatwg.org/multipage/interaction.html#datatransferitem
This should link to https://wicg.github.io/entries-api/#html-data

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webmidi/MIDIPort.idl (right):

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webmidi/MIDIPort.idl:61: readonly attribute
DOMString? manufacturer;
Oh my, I've lied again. This would change the generated code I think, to make
the return value change from "" to null if a null WTF::String is returned.

Maybe it's best to compare the generated code to make sure what will remain
really doesn't change anything.

[lunalu1, 2016-12-14 09:02:26]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 09:02:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 09:15:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 09:15:51]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lunalu1, 2016-12-14 10:16:33]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 10:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2016-12-14 11:00:15]

Done. Thanks

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLInputElement.idl (right):

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLInputElement.idl:83: [RaisesException,
ImplementedAs=selectionStartForBinding] attribute long? selectionStart;
On 2016/12/13 22:37:31, foolip wrote:
> OK, so I said that making readonly attributes nullable doesn't change the
> generated code, but it's not always true. For things like WTF::String and
> pointers that can be null, it just works, but for integers etc. an extra
> argument is added to the getter, which is why the compile is now failing.
> 
> I'd exclude this change, because it would also need to actually return null in
> some situation for it to be useful, which then requires tests and so on.

Done.

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.idl
(right):

https://codereview.chromium.org/2569993003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.idl:31:
// https://html.spec.whatwg.org/multipage/interaction.html#datatransferitem
On 2016/12/13 22:37:31, foolip wrote:
> This should link to https://wicg.github.io/entries-api/#html-data

Done.

[lunalu1, 2016-12-14 11:23:27]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 11:23:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-12-14 11:33:31]

The CQ bit was unchecked by foolip@chromium.org

[foolip, 2016-12-14 11:33:34]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-12-14 11:33:35]

lgtm

[commit-bot: I haz the power, 2016-12-14 11:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 13:12:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481715214542990,
"parent_rev": "4918b0af4e61c4a0b93fc71eba73bdcb9178b21e", "commit_rev":
"f9dbacae320adfe69ad3653375f8b51d6e4e60b4"}

[commit-bot: I haz the power, 2016-12-14 13:12:25]

Description was changed from

==========
Low risk non-nullable => nullable change

Made the following arguments / attributes nullable to match the spec.

BUG=662005
==========

to

==========
Low risk non-nullable => nullable change

Made the following arguments / attributes nullable to match the spec.

BUG=662005

Review-Url: https://codereview.chromium.org/2569993003
==========

[commit-bot: I haz the power, 2016-12-14 13:12:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 13:14:20]

Description was changed from

==========
Low risk non-nullable => nullable change

Made the following arguments / attributes nullable to match the spec.

BUG=662005

Review-Url: https://codereview.chromium.org/2569993003
==========

to

==========
Low risk non-nullable => nullable change

Made the following arguments / attributes nullable to match the spec.

BUG=662005

Committed: https://crrev.com/8734aac57d4f724768a53326542d911f1836ad45
Cr-Commit-Position: refs/heads/master@{#438498}
==========

[commit-bot: I haz the power, 2016-12-14 13:14:21]

Patchset 4 (id:??) landed as
https://crrev.com/8734aac57d4f724768a53326542d911f1836ad45
Cr-Commit-Position: refs/heads/master@{#438498}