Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: third_party/WebKit/Source/modules/webmidi/MIDIPort.idl

Issue 2569993003: Low risk non-nullable => nullable change (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 }; 51 };
52 52
53 // https://webaudio.github.io/web-midi-api/#MIDIPort 53 // https://webaudio.github.io/web-midi-api/#MIDIPort
54 54
55 [ 55 [
56 ActiveScriptWrappable, 56 ActiveScriptWrappable,
57 DependentLifetime, 57 DependentLifetime,
58 ] interface MIDIPort : EventTarget { 58 ] interface MIDIPort : EventTarget {
59 readonly attribute MIDIPortConnectionState connection; 59 readonly attribute MIDIPortConnectionState connection;
60 readonly attribute DOMString id; 60 readonly attribute DOMString id;
61 readonly attribute DOMString manufacturer; 61 readonly attribute DOMString? manufacturer;
foolip 2016/12/13 22:37:31 Oh my, I've lied again. This would change the gene
62 readonly attribute DOMString name; 62 readonly attribute DOMString? name;
63 readonly attribute MIDIPortDeviceState state; 63 readonly attribute MIDIPortDeviceState state;
64 readonly attribute MIDIPortType type; 64 readonly attribute MIDIPortType type;
65 readonly attribute DOMString version; 65 readonly attribute DOMString? version;
66 66
67 attribute EventHandler onstatechange; 67 attribute EventHandler onstatechange;
68 68
69 [CallWith=ScriptState] Promise open(); 69 [CallWith=ScriptState] Promise open();
70 [CallWith=ScriptState] Promise close(); 70 [CallWith=ScriptState] Promise close();
71 }; 71 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698