Low risk non-nullable => nullable change

third_party/WebKit/Source/core/html/HTMLInputElement.idl

 /*
  * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 62 matching lines @@
     readonly attribute ValidityState validity;
     readonly attribute DOMString validationMessage;
     boolean checkValidity();
     boolean reportValidity();
     void setCustomValidity(DOMString error);
 
     readonly attribute NodeList labels;
 
     void select();
     // FIXME: selectionStart and selectionEnd should be unsigned long.
-    [RaisesException, ImplementedAs=selectionStartForBinding] attribute long selectionStart;
-    [RaisesException, ImplementedAs=selectionEndForBinding] attribute long selectionEnd;
-    [RaisesException, ImplementedAs=selectionDirectionForBinding] attribute DOMString selectionDirection;
+    [RaisesException, ImplementedAs=selectionStartForBinding] attribute long? selectionStart;

[foolip, 2016/12/13 22:37:31]

OK, so I said that making readonly attributes nullable doesn't change the
generated code, but it's not always true. For things like WTF::String and
pointers that can be null, it just works, but for integers etc. an extra
argument is added to the getter, which is why the compile is now failing.

I'd exclude this change, because it would also need to actually return null in
some situation for it to be useful, which then requires tests and so on.

[lunalu1, 2016/12/14 11:00:14]

Done.

+    [RaisesException, ImplementedAs=selectionEndForBinding] attribute long? selectionEnd;
+    [RaisesException, ImplementedAs=selectionDirectionForBinding] attribute DOMString? selectionDirection;
     [RaisesException] void setRangeText(DOMString replacement);
     [RaisesException] void setRangeText(DOMString replacement,
                                         unsigned long start,
                                         unsigned long end,
                                         optional SelectionMode selectionMode = "preserve");
     // FIXME: The start and end arguments should be unsigned long and should not have [Default=Undefined].
     [RaisesException, ImplementedAs=setSelectionRangeForBinding]
     void setSelectionRange([Default=Undefined] optional long start,
                            [Default=Undefined] optional long end,
                            optional DOMString direction);
 
     // obsolete members
     // https://html.spec.whatwg.org/#HTMLInputElement-partial
     [CEReactions, Reflect] attribute DOMString align;
     [CEReactions, Reflect] attribute DOMString useMap;
 
     // HTML autocapitalize proposal
     // https://github.com/mounirlamouri/html-autocapitalize/blob/master/proposal.md
     [Measure] attribute DOMString autocapitalize;
 
     // HTML Media Capture
     // http://www.w3.org/TR/html-media-capture/
     [RuntimeEnabled=MediaCapture, Reflect] attribute boolean capture;
 
     // Non-standard APIs
     [Reflect, MeasureAs=PrefixedDirectoryAttribute] attribute boolean webkitdirectory;
     [Reflect, MeasureAs=IncrementalAttribute] attribute boolean incremental;
 };