Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2569733002: Even less reliance on Compiler.closedWorld (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -332 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 4 chunks +10 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 6 chunks +12 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 5 chunks +23 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 10 chunks +15 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +10 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 12 chunks +30 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 15 chunks +30 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 12 chunks +26 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 9 chunks +29 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 7 chunks +28 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 13 chunks +24 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 32 chunks +56 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 4 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dump_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (left): https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/compiler.dart#oldcode489 pkg/compiler/lib/src/compiler.dart:489: Element get unnamedListConstructor { Moved to CommonElements https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File ...
4 years ago (2016-12-12 15:37:37 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1483 pkg/compiler/lib/src/compiler.dart:1483: if (_unnamedListConstructor != null) return _unnamedListConstructor; while we ...
4 years ago (2016-12-12 15:50:16 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as a2483321a3713cd92d64f2181d5f66a31cf912ec (presubmit successful).
4 years ago (2016-12-13 09:38:21 UTC) #5
Johnni Winther
4 years ago (2016-12-13 11:20:28 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:1483: if (_unnamedListConstructor != null)
return _unnamedListConstructor;
On 2016/12/12 15:50:16, Siggi Cherem (dart-lang) wrote:
> while we are at it, switch to ??=

Done.

https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2569733002/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:173: CoreClasses get coreClasses =>
closedWorld.coreClasses;
On 2016/12/12 15:50:16, Siggi Cherem (dart-lang) wrote:
> should we remove this one and use commonElements in it's place?

Done.

Powered by Google App Engine
This is Rietveld 408576698