Even less reliance on Compiler.closedWorld

pkg/compiler/lib/src/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements;
 
 import '../common.dart';
 import '../common/resolution.dart' show Resolution;
 import '../compiler.dart' show Compiler;
 import '../constants/constructors.dart';
 import '../constants/expressions.dart';
-import '../core_types.dart' show CoreClasses;
+import '../core_types.dart' show CoreClasses, CommonElements;
 import '../dart_types.dart';
 import '../ordered_typeset.dart' show OrderedTypeSet;
 import '../resolution/scope.dart' show Scope;
 import '../resolution/tree_elements.dart' show TreeElements;
 import '../script.dart';
 import '../tokens/token.dart'
     show Token, isUserDefinableOperator, isMinusOperator;
 import '../tree/tree.dart';
 import '../util/characters.dart' show $_;
 import '../util/util.dart';
+import '../world.dart' show ClosedWorld;
 import 'entities.dart';
 import 'visitor.dart' show ElementVisitor;
 
 part 'names.dart';
 
 const int STATE_NOT_STARTED = 0;
 const int STATE_STARTED = 1;
 const int STATE_DONE = 2;
 
 class ElementCategory {
@@ skipping 635 matching lines @@
     if (identical(op, '<<=')) return '<<';
     if (identical(op, '>>=')) return '>>';
     if (identical(op, '&=')) return '&';
     if (identical(op, '^=')) return '^';
     if (identical(op, '|=')) return '|';
     if (identical(op, '??=')) return '??';
 
     return null;
   }
 
-  static bool isNumberOrStringSupertype(Element element, Compiler compiler) {
-    LibraryElement coreLibrary = compiler.commonElements.coreLibrary;
+  static bool isNumberOrStringSupertype(
+      Element element, CommonElements commonElements) {
+    LibraryElement coreLibrary = commonElements.coreLibrary;
     return (element == coreLibrary.find('Comparable'));
   }
 
-  static bool isStringOnlySupertype(Element element, Compiler compiler) {
-    LibraryElement coreLibrary = compiler.commonElements.coreLibrary;
+  static bool isStringOnlySupertype(
+      Element element, CommonElements commonElements) {
+    LibraryElement coreLibrary = commonElements.coreLibrary;
     return element == coreLibrary.find('Pattern');
   }
 
-  static bool isListSupertype(Element element, Compiler compiler) {
-    LibraryElement coreLibrary = compiler.commonElements.coreLibrary;
+  static bool isListSupertype(Element element, CommonElements commonElements) {
+    LibraryElement coreLibrary = commonElements.coreLibrary;
     return element == coreLibrary.find('Iterable');
   }
 
   /// A `compareTo` function that places [Element]s in a consistent order based
   /// on the source code order.
   static int compareByPosition(Element a, Element b) {
     if (identical(a, b)) return 0;
     int r = _compareLibraries(a.library, b.library);
     if (r != 0) return r;
     r = _compareCompilationUnits(a.compilationUnit, b.compilationUnit);
@@ skipping 63 matching lines @@
     Uri aUri = a.script.readableUri;
     Uri bUri = b.script.readableUri;
     return '${aUri}'.compareTo('${bUri}');
   }
 
   static List<Element> sortedByPosition(Iterable<Element> elements) {
     return elements.toList()..sort(compareByPosition);
   }
 
   static bool isFixedListConstructorCall(
-      Element element, Send node, Compiler compiler) {
-    return element == compiler.unnamedListConstructor &&
+      Element element, Send node, CommonElements commonElements) {
+    return element == commonElements.unnamedListConstructor &&
         node.isCall &&
         !node.arguments.isEmpty &&
         node.arguments.tail.isEmpty;
   }
 
   static bool isGrowableListConstructorCall(
-      Element element, Send node, Compiler compiler) {
-    return element == compiler.unnamedListConstructor &&
+      Element element, Send node, CommonElements commonElements) {
+    return element == commonElements.unnamedListConstructor &&
         node.isCall &&
         node.arguments.isEmpty;
   }
 
   static bool isFilledListConstructorCall(
-      Element element, Send node, Compiler compiler) {
-    return element == compiler.filledListConstructor &&
+      Element element, Send node, CommonElements commonElements) {
+    return element == commonElements.filledListConstructor &&
         node.isCall &&
         !node.arguments.isEmpty &&
         !node.arguments.tail.isEmpty &&
         node.arguments.tail.tail.isEmpty;
   }
 
   static bool isConstructorOfTypedArraySubclass(
-      Element element, Compiler compiler) {
-    if (compiler.commonElements.typedDataLibrary == null) return false;
+      Element element, ClosedWorld closedWorld) {
+    if (closedWorld.commonElements.typedDataLibrary == null) return false;
     if (!element.isConstructor) return false;
     ConstructorElement constructor = element.implementation;
     constructor = constructor.effectiveTarget;
     ClassElement cls = constructor.enclosingClass;
-    return cls.library == compiler.commonElements.typedDataLibrary &&
-        compiler.backend.isNative(cls) &&
-        compiler.closedWorld
-            .isSubtypeOf(cls, compiler.commonElements.typedDataClass) &&
-        compiler.closedWorld.isSubtypeOf(cls, compiler.coreClasses.listClass) &&
+    return cls.library == closedWorld.commonElements.typedDataLibrary &&
+        closedWorld.backendClasses.isNative(cls) &&
+        closedWorld.isSubtypeOf(
+            cls, closedWorld.commonElements.typedDataClass) &&
+        closedWorld.isSubtypeOf(cls, closedWorld.coreClasses.listClass) &&
         constructor.name == '';
   }
 
   static bool switchStatementHasContinue(
       SwitchStatement node, TreeElements elements) {
     for (SwitchCase switchCase in node.cases) {
       for (Node labelOrCase in switchCase.labelsAndCases) {
         Node label = labelOrCase.asLabel();
         if (label != null) {
           LabelDefinition labelElement = elements.getLabelDefinition(label);
@@ skipping 1113 matching lines @@
   /// by a field.
   bool get isDeclaredByField;
 
   /// Returns `true` if this member is abstract.
   bool get isAbstract;
 
   /// If abstract, [implementation] points to the overridden concrete member,
   /// if any. Otherwise [implementation] points to the member itself.
   Member get implementation;
 }