Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2167)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2569733002: Even less reliance on Compiler.closedWorld (Closed)
Patch Set: Updated cf. comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/core_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 82895d960a01c9ef38e0e73e01ea8da29947194b..d3e98c03ead3d4a9f0d6c6c315e55640b728adae 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -485,20 +485,6 @@ abstract class Compiler implements LibraryLoaderListener {
// [JavaScriptBackend]. Currently needed for testing.
String get patchVersion => backend.patchVersion;
- Element _unnamedListConstructor;
- Element get unnamedListConstructor {
- if (_unnamedListConstructor != null) return _unnamedListConstructor;
- return _unnamedListConstructor =
- coreClasses.listClass.lookupDefaultConstructor();
- }
-
- Element _filledListConstructor;
- Element get filledListConstructor {
- if (_filledListConstructor != null) return _filledListConstructor;
- return _filledListConstructor =
- coreClasses.listClass.lookupConstructor("filled");
- }
-
/**
* Get an [Uri] pointing to a patch for the dart: library with
* the given path. Returns null if there is no patch.
@@ -748,7 +734,7 @@ abstract class Compiler implements LibraryLoaderListener {
if (options.dumpInfo) {
dumpInfoTask.reportSize(programSize);
- dumpInfoTask.dumpInfo();
+ dumpInfoTask.dumpInfo(closedWorld);
}
backend.sourceInformationStrategy.onComplete();
@@ -763,7 +749,7 @@ abstract class Compiler implements LibraryLoaderListener {
WorldImpl world = resolverWorld.openWorld.closeWorld(reporter);
// Compute whole-program-knowledge that the backend needs. (This might
// require the information computed in [world.closeWorld].)
- backend.onResolutionComplete(world);
+ backend.onResolutionComplete(world, world);
deferredLoadTask.onResolutionComplete(mainFunction);
@@ -1491,6 +1477,14 @@ class _CompilerCoreTypes implements CoreTypes, CoreClasses, CommonElements {
}
return element;
}
+
+ ConstructorElement _unnamedListConstructor;
+ ConstructorElement get unnamedListConstructor =>
+ _unnamedListConstructor ??= listClass.lookupDefaultConstructor();
+
+ ConstructorElement _filledListConstructor;
+ ConstructorElement get filledListConstructor =>
+ _filledListConstructor ??= listClass.lookupConstructor("filled");
}
class CompilerDiagnosticReporter extends DiagnosticReporter {
« no previous file with comments | « pkg/compiler/lib/src/common/backend_api.dart ('k') | pkg/compiler/lib/src/core_types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698