Even less reliance on Compiler.closedWorld

pkg/compiler/lib/src/ssa/interceptor_simplifier.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import '../common/codegen.dart' show CodegenWorkItem;
+import '../common/backend_api.dart' show BackendClasses;
 import '../compiler.dart' show Compiler;
 import '../constants/constant_system.dart';
 import '../constants/values.dart';
 import '../elements/elements.dart';
-import '../js_backend/backend_helpers.dart' show BackendHelpers;
-import '../js_backend/js_backend.dart';
+import '../js_backend/backend.dart';
 import '../types/types.dart';
 import '../universe/selector.dart' show Selector;
 import '../world.dart' show ClosedWorld;
 import 'nodes.dart';
 import 'optimize.dart';
 
 /**
  * This phase simplifies interceptors in multiple ways:
  *
  * 1) If the interceptor is for an object whose type is known, it
@@ skipping 18 matching lines @@
   final String name = "SsaSimplifyInterceptors";
   final ConstantSystem constantSystem;
   final Compiler compiler;
   final Element element;
   HGraph graph;
 
   SsaSimplifyInterceptors(this.compiler, this.constantSystem, this.element);
 
   JavaScriptBackend get backend => compiler.backend;
 
-  BackendHelpers get helpers => backend.helpers;
+  ClosedWorld get closedWorld => compiler.closedWorld;
 
-  ClosedWorld get closedWorld => compiler.closedWorld;
+  BackendClasses get backendClasses => closedWorld.backendClasses;
 
   void visitGraph(HGraph graph) {
     this.graph = graph;
     visitDominatorTree(graph);
   }
 
   void visitBasicBlock(HBasicBlock node) {
     currentBlock = node;
 
     HInstruction instruction = node.first;
@@ skipping 32 matching lines @@
     return false;
   }
 
   bool canUseSelfForInterceptor(
       HInstruction receiver, Set<ClassElement> interceptedClasses) {
     if (receiver.canBePrimitive(closedWorld)) {
       // Primitives always need interceptors.
       return false;
     }
     if (receiver.canBeNull() &&
-        interceptedClasses.contains(helpers.jsNullClass)) {
+        interceptedClasses.contains(backendClasses.nullImplementation)) {
       // Need the JSNull interceptor.
       return false;
     }
 
     // All intercepted classes extend `Interceptor`, so if the receiver can't be
     // a class extending `Interceptor` then it can be called directly.
-    return new TypeMask.nonNullSubclass(helpers.jsInterceptorClass, closedWorld)
+    return new TypeMask.nonNullSubclass(
+            backend.helpers.jsInterceptorClass, closedWorld)
         .isDisjoint(receiver.instructionType, closedWorld);
   }
 
   HInstruction tryComputeConstantInterceptor(
       HInstruction input, Set<ClassElement> interceptedClasses) {
     if (input == graph.explicitReceiverParameter) {
       // If `explicitReceiverParameter` is set it means the current method is an
       // interceptor method, and `this` is the interceptor.  The caller just did
       // `getInterceptor(foo).currentMethod(foo)` to enter the current method.
       return graph.thisInstruction;
@@ skipping 13 matching lines @@
 
     ConstantValue constant =
         new InterceptorConstantValue(constantInterceptor.thisType);
     return graph.addConstant(constant, compiler);
   }
 
   ClassElement tryComputeConstantInterceptorFromType(
       TypeMask type, Set<ClassElement> interceptedClasses) {
     if (type.isNullable) {
       if (type.isNull) {
-        return helpers.jsNullClass;
+        return backendClasses.nullImplementation;
       }
     } else if (type.containsOnlyInt(closedWorld)) {
-      return helpers.jsIntClass;
+      return backendClasses.intImplementation;
     } else if (type.containsOnlyDouble(closedWorld)) {
-      return helpers.jsDoubleClass;
+      return backendClasses.doubleImplementation;
     } else if (type.containsOnlyBool(closedWorld)) {
-      return helpers.jsBoolClass;
+      return backendClasses.boolImplementation;
     } else if (type.containsOnlyString(closedWorld)) {
-      return helpers.jsStringClass;
-    } else if (type.satisfies(helpers.jsArrayClass, closedWorld)) {
-      return helpers.jsArrayClass;
+      return backendClasses.stringImplementation;
+    } else if (type.satisfies(backendClasses.listImplementation, closedWorld)) {
+      return backendClasses.listImplementation;
     } else if (type.containsOnlyNum(closedWorld) &&
-        !interceptedClasses.contains(helpers.jsIntClass) &&
-        !interceptedClasses.contains(helpers.jsDoubleClass)) {
+        !interceptedClasses.contains(backendClasses.intImplementation) &&
+        !interceptedClasses.contains(backendClasses.doubleImplementation)) {
       // If the method being intercepted is not defined in [int] or [double] we
       // can safely use the number interceptor.  This is because none of the
       // [int] or [double] methods are called from a method defined on [num].
-      return helpers.jsNumberClass;
+      return backendClasses.numImplementation;
     } else {
       // Try to find constant interceptor for a native class.  If the receiver
       // is constrained to a leaf native class, we can use the class's
       // interceptor directly.
 
       // TODO(sra): Key DOM classes like Node, Element and Event are not leaf
       // classes.  When the receiver type is not a leaf class, we might still be
       // able to use the receiver class as a constant interceptor.  It is
       // usually the case that methods defined on a non-leaf class don't test
       // for a subclass or call methods defined on a subclass.  Provided the
       // code is completely insensitive to the specific instance subclasses, we
       // can use the non-leaf class directly.
       ClassElement element = type.singleClass(closedWorld);
-      if (element != null && backend.isNative(element)) {
+      if (element != null && backendClasses.isNative(element)) {
         return element;
       }
     }
 
     return null;
   }
 
   HInstruction findDominator(Iterable<HInstruction> instructions) {
     HInstruction result;
     L1:
@@ skipping 26 matching lines @@
     // a HTypeKnown instruction.
 
     int useCount(HInstruction user, HInstruction used) =>
         user.inputs.where((input) => input == used).length;
 
     Set<ClassElement> interceptedClasses;
     HInstruction dominator = findDominator(node.usedBy);
     // If there is a call that dominates all other uses, we can use just the
     // selector of that instruction.
     if (dominator is HInvokeDynamic &&
-        dominator.isCallOnInterceptor(compiler) &&
+        dominator.isCallOnInterceptor(closedWorld) &&
         node == dominator.receiver &&
         useCount(dominator, node) == 1) {
       interceptedClasses =
           backend.getInterceptedClassesOn(dominator.selector.name);
 
       // If we found that we need number, we must still go through all
       // uses to check if they require int, or double.
-      if (interceptedClasses.contains(helpers.jsNumberClass) &&
-          !(interceptedClasses.contains(helpers.jsDoubleClass) ||
-              interceptedClasses.contains(helpers.jsIntClass))) {
+      if (interceptedClasses.contains(backendClasses.numImplementation) &&
+          !(interceptedClasses.contains(backendClasses.doubleImplementation) ||
+              interceptedClasses.contains(backendClasses.intImplementation))) {
         Set<ClassElement> required;
         for (HInstruction user in node.usedBy) {
           if (user is! HInvoke) continue;
           Set<ClassElement> intercepted =
               backend.getInterceptedClassesOn(user.selector.name);
-          if (intercepted.contains(helpers.jsIntClass)) {
+          if (intercepted.contains(backendClasses.intImplementation)) {
             required ??= new Set<ClassElement>();
-            required.add(helpers.jsIntClass);
+            required.add(backendClasses.intImplementation);
           }
-          if (intercepted.contains(helpers.jsDoubleClass)) {
+          if (intercepted.contains(backendClasses.doubleImplementation)) {
             required ??= new Set<ClassElement>();
-            required.add(helpers.jsDoubleClass);
+            required.add(backendClasses.doubleImplementation);
           }
         }
         // Don't modify the result of [backend.getInterceptedClassesOn].
         if (required != null) {
           interceptedClasses = interceptedClasses.union(required);
         }
       }
     } else {
       interceptedClasses = new Set<ClassElement>();
       for (HInstruction user in node.usedBy) {
         if (user is HInvokeDynamic &&
-            user.isCallOnInterceptor(compiler) &&
+            user.isCallOnInterceptor(closedWorld) &&
             node == user.receiver &&
             useCount(user, node) == 1) {
           interceptedClasses
               .addAll(backend.getInterceptedClassesOn(user.selector.name));
         } else if (user is HInvokeSuper &&
-            user.isCallOnInterceptor(compiler) &&
+            user.isCallOnInterceptor(closedWorld) &&
             node == user.receiver &&
             useCount(user, node) == 1) {
           interceptedClasses
               .addAll(backend.getInterceptedClassesOn(user.selector.name));
         } else {
           // Use a most general interceptor for other instructions, example,
           // is-checks and escaping interceptors.
           interceptedClasses.addAll(backend.interceptedClasses);
           break;
         }
@@ skipping 27 matching lines @@
     // If it is a conditional constant interceptor and was not strengthened to a
     // constant interceptor then there is nothing more we can do.
     if (node.isConditionalConstantInterceptor) return false;
 
     // Do we have an 'almost constant' interceptor?  The receiver could be
     // `null` but not any other JavaScript falsy value, `null` values cause
     // `NoSuchMethodError`s, and if the receiver was not null we would have a
     // constant interceptor `C`.  Then we can use `(receiver && C)` for the
     // interceptor.
     if (receiver.canBeNull()) {
-      if (!interceptedClasses.contains(helpers.jsNullClass)) {
+      if (!interceptedClasses.contains(backendClasses.nullImplementation)) {
         // Can use `(receiver && C)` only if receiver is either null or truthy.
         if (!(receiver.canBePrimitiveNumber(closedWorld) ||
             receiver.canBePrimitiveBoolean(closedWorld) ||
             receiver.canBePrimitiveString(closedWorld))) {
           ClassElement interceptorClass = tryComputeConstantInterceptorFromType(
               receiver.instructionType.nonNullable(), interceptedClasses);
           if (interceptorClass != null) {
             HInstruction constantInstruction = graph.addConstant(
                 new InterceptorConstantValue(interceptorClass.thisType),
                 compiler);
@@ skipping 95 matching lines @@
       instruction = new HInvokeDynamicMethod(
           selector, mask, inputs, node.instructionType, true);
     }
 
     HBasicBlock block = node.block;
     block.addAfter(node, instruction);
     block.rewrite(node, instruction);
     return true;
   }
 }