[NTPSnippets] Switch from TickClock to Clock for storing the last background fetched time.

[NTPSnippets] Switch from TickClock to Clock for storing the last background fetched time.
Expose the last background fetch time on snippets internals and allow to trigger background fetches manually from snippets internal.

BUG=665873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5
Cr-Commit-Position: refs/heads/master@{#438262}

[markusheintz_, 2016-12-13 11:59:50]

Description was changed from

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=TBD
==========

to

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[markusheintz_, 2016-12-13 12:05:13]

Description was changed from

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=665873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[markusheintz_, 2016-12-13 12:05:13]

markusheintz@chromium.org changed reviewers:
+ jkrcal@chromium.org

[markusheintz_, 2016-12-13 12:10:52]

Jan PTAL thanks

[markusheintz_, 2016-12-13 12:11:10]

The CQ bit was checked by markusheintz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 12:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-13 13:06:54]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-12-13 13:06:54]

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/resources/sn...
File chrome/browser/resources/snippets_internals.html (right):

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/resources/sn...
chrome/browser/resources/snippets_internals.html:103: Fetch Remote Suggestion in
the Background
Nit: "suggestions", and no need to capitalize beyond the first word.

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/ui/webui/sni...
File chrome/browser/ui/webui/snippets_internals_message_handler.cc (right):

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/ui/webui/sni...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:90:
pref_service_(pref_service),
Couldn't you get the PrefService from the profile in RegisterMessages?
Alternatively, pass the profile in the constructor and get all the dependencies
here (the comment below seems outdated, as this is in fact how we get the
PrefService).

[commit-bot: I haz the power, 2016-12-13 13:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 13:14:29]

Dry run: This issue passed the CQ dry run.

[markusheintz_, 2016-12-13 14:00:15]

The CQ bit was checked by markusheintz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 14:00:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[markusheintz_, 2016-12-13 14:01:28]

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/resources/sn...
File chrome/browser/resources/snippets_internals.html (right):

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/resources/sn...
chrome/browser/resources/snippets_internals.html:103: Fetch Remote Suggestion in
the Background
On 2016/12/13 13:06:54, Bernhard Bauer wrote:
> Nit: "suggestions", and no need to capitalize beyond the first word.

Done.

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/ui/webui/sni...
File chrome/browser/ui/webui/snippets_internals_message_handler.cc (right):

https://codereview.chromium.org/2569663004/diff/1/chrome/browser/ui/webui/sni...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:90:
pref_service_(pref_service),
On 2016/12/13 13:06:54, Bernhard Bauer wrote:
> Couldn't you get the PrefService from the profile in RegisterMessages?
> Alternatively, pass the profile in the constructor and get all the
dependencies
> here (the comment below seems outdated, as this is in fact how we get the
> PrefService).

Oh good catch I didn't notice this. I think this looks like a hack. Passing all
dependencies in now.

[markusheintz_, 2016-12-13 14:02:22]

Address comments bauerb

[markusheintz_, 2016-12-13 14:11:21]

The CQ bit was checked by markusheintz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 14:11:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[markusheintz_, 2016-12-13 14:14:27]

Add a DCHECK to check that the num or args passed to the new method is 0

[markusheintz_, 2016-12-13 14:51:33]

The CQ bit was checked by markusheintz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 14:51:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-13 15:06:11]

LGTM, thanks!

[jkrcal, 2016-12-13 15:11:12]

lgtm

[commit-bot: I haz the power, 2016-12-13 15:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 15:56:55]

Dry run: This issue passed the CQ dry run.

[markusheintz_, 2016-12-13 19:42:16]

The CQ bit was checked by markusheintz@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:43:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 19:51:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481658136383410,
"parent_rev": "2a0b4a44bb555829a773f331c0c2109625b7e0a7", "commit_rev":
"68e5acd969d178a4e4a2c2f27680ae90d41d323d"}

[commit-bot: I haz the power, 2016-12-13 19:51:44]

Description was changed from

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=665873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=665873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2569663004
==========

[commit-bot: I haz the power, 2016-12-13 19:51:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 19:55:24]

Description was changed from

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=665873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2569663004
==========

to

==========
[NTPSnippets] Switch from TickClock to Clock for storing the last background
fetched time.
Expose the last background fetch time on snippets internals and allow to trigger
background fetches manually from snippets internal.

BUG=665873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5
Cr-Commit-Position: refs/heads/master@{#438262}
==========

[commit-bot: I haz the power, 2016-12-13 19:55:25]

Patchset 3 (id:??) landed as
https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5
Cr-Commit-Position: refs/heads/master@{#438262}