Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider.cc

Issue 2569663004: [NTPSnippets] Switch from TickClock to Clock for storing the last background fetched time. (Closed)
Patch Set: Add a DCHECK to check that the num or args passed to the new method is 0 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider.cc b/components/ntp_snippets/remote/remote_suggestions_provider.cc
index 4ff354f6b697750382057030828db4b3d856afab..a33d4d9a3144c9acbdda695d636799a4b0d8f193 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider.cc
@@ -19,6 +19,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task_runner_util.h"
+#include "base/time/default_clock.h"
#include "base/time/default_tick_clock.h"
#include "base/time/time.h"
#include "base/values.h"
@@ -251,7 +252,7 @@ RemoteSuggestionsProvider::RemoteSuggestionsProvider(
thumbnail_requests_throttler_(
pref_service,
RequestThrottler::RequestType::CONTENT_SUGGESTION_THUMBNAIL),
- tick_clock_(base::MakeUnique<base::DefaultTickClock>()) {
+ clock_(base::MakeUnique<base::DefaultClock>()) {
pref_service_->ClearPref(kDeprecatedSnippetHostsPref);
RestoreCategoriesFromPrefs();
@@ -719,7 +720,7 @@ void RemoteSuggestionsProvider::OnFetchFinished(
if (!interactive_request &&
fetch_result == NTPSnippetsFetcher::FetchResult::SUCCESS) {
pref_service_->SetInt64(prefs::kLastSuccessfulBackgroundFetchTime,
- tick_clock_->NowTicks().ToInternalValue());
+ clock_->Now().ToInternalValue());
}
// Mark all categories as not provided by the server in the latest fetch. The

Powered by Google App Engine
This is Rietveld 408576698