[NTPSnippets] Switch from TickClock to Clock for storing the last background fetched time.

chrome/browser/ui/webui/snippets_internals_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/i18n/time_formatting.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/optional.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
+#include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_features.h"
 #include "components/ntp_snippets/category_info.h"
 #include "components/ntp_snippets/features.h"
+#include "components/ntp_snippets/pref_names.h"
+#include "components/ntp_snippets/remote/remote_suggestions_provider.h"
 #include "components/ntp_snippets/switches.h"
+#include "components/prefs/pref_service.h"
 #include "content/public/browser/web_ui.h"
 
 using ntp_snippets::ContentSuggestion;
 using ntp_snippets::Category;
 using ntp_snippets::CategoryInfo;
 using ntp_snippets::CategoryStatus;
 using ntp_snippets::KnownCategories;
 using ntp_snippets::UserClassifier;
 
 namespace {
@@ skipping 31 matching lines @@
     case CategoryStatus::SIGNED_OUT:
       return "SIGNED_OUT";
     case CategoryStatus::LOADING_ERROR:
       return "LOADING_ERROR";
   }
   return std::string();
 }
 
 }  // namespace
 
-SnippetsInternalsMessageHandler::SnippetsInternalsMessageHandler()
+SnippetsInternalsMessageHandler::SnippetsInternalsMessageHandler(
+    ntp_snippets::ContentSuggestionsService* content_suggestions_service,
+    PrefService* pref_service)
     : content_suggestions_service_observer_(this),
       dom_loaded_(false),
-      ntp_snippets_service_(nullptr),
-      content_suggestions_service_(nullptr),
+      content_suggestions_service_(content_suggestions_service),
+      remote_suggestions_provider_(
+          content_suggestions_service_->ntp_snippets_service()),
+      pref_service_(pref_service),
       weak_ptr_factory_(this) {}
 
 SnippetsInternalsMessageHandler::~SnippetsInternalsMessageHandler() {}
 
 void SnippetsInternalsMessageHandler::RegisterMessages() {
-  // Additional initialization (web_ui() does not work from the constructor).
-  Profile* profile = Profile::FromWebUI(web_ui());
-
-  content_suggestions_service_ =
-      ContentSuggestionsServiceFactory::GetInstance()->GetForProfile(profile);
-  content_suggestions_service_observer_.Add(content_suggestions_service_);
-
-  ntp_snippets_service_ = content_suggestions_service_->ntp_snippets_service();
-
   web_ui()->RegisterMessageCallback(
-      "refreshContent",
-      base::Bind(&SnippetsInternalsMessageHandler::HandleRefreshContent,
+      "clearCachedSuggestions",
+      base::Bind(&SnippetsInternalsMessageHandler::HandleClearCachedSuggestions,
                  base::Unretained(this)));
 
   web_ui()->RegisterMessageCallback(
-      "download", base::Bind(&SnippetsInternalsMessageHandler::HandleDownload,
-                             base::Unretained(this)));
-
-  web_ui()->RegisterMessageCallback(
-      "clearCachedSuggestions",
-      base::Bind(&SnippetsInternalsMessageHandler::HandleClearCachedSuggestions,
+      "clearClassification",
+      base::Bind(&SnippetsInternalsMessageHandler::ClearClassification,
                  base::Unretained(this)));
 
   web_ui()->RegisterMessageCallback(
       "clearDismissedSuggestions",
       base::Bind(
           &SnippetsInternalsMessageHandler::HandleClearDismissedSuggestions,
           base::Unretained(this)));
 
   web_ui()->RegisterMessageCallback(
+      "download", base::Bind(&SnippetsInternalsMessageHandler::HandleDownload,
+                             base::Unretained(this)));
+
+  web_ui()->RegisterMessageCallback(
+      "fetchRemoteSuggestionsInTheBackground",
+      base::Bind(&SnippetsInternalsMessageHandler::
+                     FetchRemoteSuggestionsInTheBackground,
+                 base::Unretained(this)));
+
+  web_ui()->RegisterMessageCallback(
+      "refreshContent",
+      base::Bind(&SnippetsInternalsMessageHandler::HandleRefreshContent,
+                 base::Unretained(this)));
+
+  web_ui()->RegisterMessageCallback(
       "toggleDismissedSuggestions",
       base::Bind(
           &SnippetsInternalsMessageHandler::HandleToggleDismissedSuggestions,
           base::Unretained(this)));
 
-  web_ui()->RegisterMessageCallback(
-      "clearClassification",
-      base::Bind(
-          &SnippetsInternalsMessageHandler::ClearClassification,
-          base::Unretained(this)));
+  content_suggestions_service_observer_.Add(content_suggestions_service_);
 }
 
 void SnippetsInternalsMessageHandler::OnNewSuggestions(Category category) {
   if (!dom_loaded_)
     return;
   SendContentSuggestions();
 }
 
 void SnippetsInternalsMessageHandler::OnCategoryStatusChanged(
     Category category,
@@ skipping 39 matching lines @@
 
   SendAllContent();
 }
 
 void SnippetsInternalsMessageHandler::HandleDownload(
     const base::ListValue* args) {
   DCHECK_EQ(1u, args->GetSize());
 
   SendString("hosts-status", std::string());
 
-  if (!ntp_snippets_service_)
+  if (!remote_suggestions_provider_)
     return;
 
   std::string hosts_string;
   if (!args->GetString(0, &hosts_string))
     return;
 
   std::vector<std::string> hosts_vector = base::SplitString(
       hosts_string, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
   std::set<std::string> hosts(hosts_vector.begin(), hosts_vector.end());
 
-  ntp_snippets_service_->FetchSnippetsFromHosts(hosts,
-                                                /*interactive_request=*/true);
+  remote_suggestions_provider_->FetchSnippetsFromHosts(
+      hosts,
+      /*interactive_request=*/true);
 }
 
 void SnippetsInternalsMessageHandler::HandleClearCachedSuggestions(
     const base::ListValue* args) {
   DCHECK_EQ(1u, args->GetSize());
 
   int category_id;
   if (!args->GetInteger(0, &category_id))
     return;
 
@@ skipping 52 matching lines @@
 }
 
 void SnippetsInternalsMessageHandler::ClearClassification(
     const base::ListValue* args) {
   DCHECK_EQ(0u, args->GetSize());
   content_suggestions_service_->user_classifier()
       ->ClearClassificationForDebugging();
   SendClassification();
 }
 
+void SnippetsInternalsMessageHandler::FetchRemoteSuggestionsInTheBackground(
+    const base::ListValue* args) {
+  DCHECK_EQ(0u, args->GetSize());
+  remote_suggestions_provider_->FetchSnippetsInTheBackground();
+}
+
 void SnippetsInternalsMessageHandler::SendAllContent() {
   SendBoolean("flag-snippets", base::FeatureList::IsEnabled(
                                    ntp_snippets::kContentSuggestionsFeature));
   SendBoolean(
       "flag-article-suggestions",
       base::FeatureList::IsEnabled(ntp_snippets::kArticleSuggestionsFeature));
   SendBoolean("flag-recent-offline-tab-suggestions",
               base::FeatureList::IsEnabled(
                   ntp_snippets::kRecentOfflineTabSuggestionsFeature));
   SendBoolean(
       "flag-asset-download-suggestions",
       base::FeatureList::IsEnabled(features::kAssetDownloadSuggestionsFeature));
   SendBoolean("flag-offline-page-download-suggestions",
               base::FeatureList::IsEnabled(
                   features::kOfflinePageDownloadSuggestionsFeature));
   SendBoolean(
       "flag-bookmark-suggestions",
       base::FeatureList::IsEnabled(ntp_snippets::kBookmarkSuggestionsFeature));
 
   SendBoolean("flag-physical-web-page-suggestions",
               base::FeatureList::IsEnabled(
                   ntp_snippets::kPhysicalWebPageSuggestionsFeature));
 
   SendClassification();
+  SendLastRemoteSuggestionsBackgroundFetchTime();
 
-  if (ntp_snippets_service_) {
-    switch (ntp_snippets_service_->snippets_fetcher()->personalization()) {
+  if (remote_suggestions_provider_) {
+    switch (
+        remote_suggestions_provider_->snippets_fetcher()->personalization()) {
       case ntp_snippets::NTPSnippetsFetcher::Personalization::kPersonal:
         SendString("switch-personalized", "Only personalized");
         break;
       case ntp_snippets::NTPSnippetsFetcher::Personalization::kBoth:
         SendString("switch-personalized",
                    "Both personalized and non-personalized");
         break;
       case ntp_snippets::NTPSnippetsFetcher::Personalization::kNonPersonal:
         SendString("switch-personalized", "Only non-personalized");
         break;
     }
 
-    SendString("switch-fetch-url",
-               ntp_snippets_service_->snippets_fetcher()->fetch_url().spec());
+    SendString(
+        "switch-fetch-url",
+        remote_suggestions_provider_->snippets_fetcher()->fetch_url().spec());
     web_ui()->CallJavascriptFunctionUnsafe(
         "chrome.SnippetsInternals.receiveJson",
         base::StringValue(
-            ntp_snippets_service_->snippets_fetcher()->last_json()));
+            remote_suggestions_provider_->snippets_fetcher()->last_json()));
   }
 
   SendContentSuggestions();
 }
 
 void SnippetsInternalsMessageHandler::SendClassification() {
   web_ui()->CallJavascriptFunctionUnsafe(
       "chrome.SnippetsInternals.receiveClassification",
       base::StringValue(content_suggestions_service_->user_classifier()
                             ->GetUserClassDescriptionForDebugging()),
       base::FundamentalValue(
           content_suggestions_service_->user_classifier()->GetEstimatedAvgTime(
               UserClassifier::Metric::NTP_OPENED)),
       base::FundamentalValue(
           content_suggestions_service_->user_classifier()->GetEstimatedAvgTime(
               UserClassifier::Metric::SUGGESTIONS_SHOWN)),
       base::FundamentalValue(
           content_suggestions_service_->user_classifier()->GetEstimatedAvgTime(
               UserClassifier::Metric::SUGGESTIONS_USED)));
 }
 
+void SnippetsInternalsMessageHandler::
+    SendLastRemoteSuggestionsBackgroundFetchTime() {
+  base::Time time = base::Time::FromInternalValue(pref_service_->GetInt64(
+      ntp_snippets::prefs::kLastSuccessfulBackgroundFetchTime));
+  web_ui()->CallJavascriptFunctionUnsafe(
+      "chrome.SnippetsInternals."
+      "receiveLastRemoteSuggestionsBackgroundFetchTime",
+      base::StringValue(base::TimeFormatShortDateAndTime(time)));
+}
+
 void SnippetsInternalsMessageHandler::SendContentSuggestions() {
   std::unique_ptr<base::ListValue> categories_list(new base::ListValue);
 
   int index = 0;
   for (Category category : content_suggestions_service_->GetCategories()) {
     CategoryStatus status =
         content_suggestions_service_->GetCategoryStatus(category);
     base::Optional<CategoryInfo> info =
         content_suggestions_service_->GetCategoryInfo(category);
     DCHECK(info);
@@ skipping 17 matching lines @@
     category_entry->SetString(
         "dismissedContainerId",
         "dismissed-suggestions-" + base::IntToString(category.id()));
     category_entry->SetString("title", info->title());
     category_entry->SetString("status", GetCategoryStatusName(status));
     category_entry->Set("suggestions", std::move(suggestions_list));
     category_entry->Set("dismissedSuggestions", std::move(dismissed_list));
     categories_list->Append(std::move(category_entry));
   }
 
-  if (ntp_snippets_service_) {
+  if (remote_suggestions_provider_) {
     const std::string& status =
-        ntp_snippets_service_->snippets_fetcher()->last_status();
+        remote_suggestions_provider_->snippets_fetcher()->last_status();
     if (!status.empty())
       SendString("hosts-status", "Finished: " + status);
   }
 
   base::DictionaryValue result;
   result.Set("list", std::move(categories_list));
   web_ui()->CallJavascriptFunctionUnsafe(
       "chrome.SnippetsInternals.receiveContentSuggestions", result);
 }
 
@@ skipping 13 matching lines @@
 
 void SnippetsInternalsMessageHandler::OnDismissedSuggestionsLoaded(
     Category category,
     std::vector<ContentSuggestion> dismissed_suggestions) {
   if (dismissed_state_[category] == DismissedState::HIDDEN)
     return;
   dismissed_suggestions_[category] = std::move(dismissed_suggestions);
   dismissed_state_[category] = DismissedState::VISIBLE;
   SendContentSuggestions();
 }