Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c72f1a22b9c407f6e1132fe43682b15e2de221fe
Cr-Commit-Position: refs/heads/master@{#438458}

[sashab, 2016-12-13 23:46:16]

Description was changed from

==========
Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2016-12-13 23:46:24]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2016-12-13 23:46:29]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:49:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[napper, 2016-12-14 02:14:02]

lgtm

[sashab, 2016-12-14 04:57:14]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-12-14 04:57:14]

The patchset sent to the CQ was uploaded after l-g-t-m from napper@chromium.org
Link to the patchset: https://codereview.chromium.org/2569013006/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-14 04:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:54:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481691434414670,
"parent_rev": "b1612be29c30b09936f1b2f3b8bee5a4232e5dc7", "commit_rev":
"e4a5581fb744b6df5ebb1cdb83db722fd8a71f28"}

[commit-bot: I haz the power, 2016-12-14 07:55:08]

Description was changed from

==========
Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569013006
==========

[commit-bot: I haz the power, 2016-12-14 07:55:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 07:58:20]

Description was changed from

==========
Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569013006
==========

to

==========
Changed EOverflow to an enum class and renamed its members

Changed EOverflow to an enum class and gave it an unsigned underlying
type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflow to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c72f1a22b9c407f6e1132fe43682b15e2de221fe
Cr-Commit-Position: refs/heads/master@{#438458}
==========

[commit-bot: I haz the power, 2016-12-14 07:58:21]

Patchset 2 (id:??) landed as
https://crrev.com/c72f1a22b9c407f6e1132fe43682b15e2de221fe
Cr-Commit-Position: refs/heads/master@{#438458}