Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2569013006: Changed EOverflow to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 void FrameView::calculateScrollbarModesFromOverflowStyle( 695 void FrameView::calculateScrollbarModesFromOverflowStyle(
696 const ComputedStyle* style, 696 const ComputedStyle* style,
697 ScrollbarMode& hMode, 697 ScrollbarMode& hMode,
698 ScrollbarMode& vMode) { 698 ScrollbarMode& vMode) {
699 hMode = vMode = ScrollbarAuto; 699 hMode = vMode = ScrollbarAuto;
700 700
701 EOverflow overflowX = style->overflowX(); 701 EOverflow overflowX = style->overflowX();
702 EOverflow overflowY = style->overflowY(); 702 EOverflow overflowY = style->overflowY();
703 703
704 if (!shouldIgnoreOverflowHidden()) { 704 if (!shouldIgnoreOverflowHidden()) {
705 if (overflowX == OverflowHidden) 705 if (overflowX == EOverflow::Hidden)
706 hMode = ScrollbarAlwaysOff; 706 hMode = ScrollbarAlwaysOff;
707 if (overflowY == OverflowHidden) 707 if (overflowY == EOverflow::Hidden)
708 vMode = ScrollbarAlwaysOff; 708 vMode = ScrollbarAlwaysOff;
709 } 709 }
710 710
711 if (overflowX == OverflowScroll) 711 if (overflowX == EOverflow::Scroll)
712 hMode = ScrollbarAlwaysOn; 712 hMode = ScrollbarAlwaysOn;
713 if (overflowY == OverflowScroll) 713 if (overflowY == EOverflow::Scroll)
714 vMode = ScrollbarAlwaysOn; 714 vMode = ScrollbarAlwaysOn;
715 } 715 }
716 716
717 void FrameView::calculateScrollbarModes( 717 void FrameView::calculateScrollbarModes(
718 ScrollbarMode& hMode, 718 ScrollbarMode& hMode,
719 ScrollbarMode& vMode, 719 ScrollbarMode& vMode,
720 ScrollbarModesCalculationStrategy strategy) { 720 ScrollbarModesCalculationStrategy strategy) {
721 #define RETURN_SCROLLBAR_MODE(mode) \ 721 #define RETURN_SCROLLBAR_MODE(mode) \
722 { \ 722 { \
723 hMode = vMode = mode; \ 723 hMode = vMode = mode; \
(...skipping 2922 matching lines...) Expand 10 before | Expand all | Expand 10 after
3646 void FrameView::setScrollbarModes(ScrollbarMode horizontalMode, 3646 void FrameView::setScrollbarModes(ScrollbarMode horizontalMode,
3647 ScrollbarMode verticalMode, 3647 ScrollbarMode verticalMode,
3648 bool horizontalLock, 3648 bool horizontalLock,
3649 bool verticalLock) { 3649 bool verticalLock) {
3650 bool needsUpdate = false; 3650 bool needsUpdate = false;
3651 3651
3652 // If the page's overflow setting has disabled scrolling, do not allow 3652 // If the page's overflow setting has disabled scrolling, do not allow
3653 // anything to override that setting, http://crbug.com/426447 3653 // anything to override that setting, http://crbug.com/426447
3654 LayoutObject* viewport = viewportLayoutObject(); 3654 LayoutObject* viewport = viewportLayoutObject();
3655 if (viewport && !shouldIgnoreOverflowHidden()) { 3655 if (viewport && !shouldIgnoreOverflowHidden()) {
3656 if (viewport->style()->overflowX() == OverflowHidden) 3656 if (viewport->style()->overflowX() == EOverflow::Hidden)
3657 horizontalMode = ScrollbarAlwaysOff; 3657 horizontalMode = ScrollbarAlwaysOff;
3658 if (viewport->style()->overflowY() == OverflowHidden) 3658 if (viewport->style()->overflowY() == EOverflow::Hidden)
3659 verticalMode = ScrollbarAlwaysOff; 3659 verticalMode = ScrollbarAlwaysOff;
3660 } 3660 }
3661 3661
3662 if (horizontalMode != horizontalScrollbarMode() && 3662 if (horizontalMode != horizontalScrollbarMode() &&
3663 !m_horizontalScrollbarLock) { 3663 !m_horizontalScrollbarLock) {
3664 m_horizontalScrollbarMode = horizontalMode; 3664 m_horizontalScrollbarMode = horizontalMode;
3665 needsUpdate = true; 3665 needsUpdate = true;
3666 } 3666 }
3667 3667
3668 if (verticalMode != verticalScrollbarMode() && !m_verticalScrollbarLock) { 3668 if (verticalMode != verticalScrollbarMode() && !m_verticalScrollbarLock) {
(...skipping 1005 matching lines...) Expand 10 before | Expand all | Expand 10 after
4674 DCHECK(m_frame->isMainFrame()); 4674 DCHECK(m_frame->isMainFrame());
4675 return m_initialViewportSize.width(); 4675 return m_initialViewportSize.width();
4676 } 4676 }
4677 4677
4678 int FrameView::initialViewportHeight() const { 4678 int FrameView::initialViewportHeight() const {
4679 DCHECK(m_frame->isMainFrame()); 4679 DCHECK(m_frame->isMainFrame());
4680 return m_initialViewportSize.height(); 4680 return m_initialViewportSize.height();
4681 } 4681 }
4682 4682
4683 } // namespace blink 4683 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698