third_party/WebKit/Source/core/page/SpatialNavigation.cpp - Issue 2569013006: Changed EOverflow to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/SpatialNavigation.cpp

Issue 2569013006: Changed EOverflow to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/SpatialNavigation.cpp

diff --git a/third_party/WebKit/Source/core/page/SpatialNavigation.cpp b/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

index ac1288b9afb29669198cf8547664636125f19e28..bfc71f874126777cb6d34609a427a99cdec4ed5f 100644

--- a/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

+++ b/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

@@ -330,21 +330,21 @@ bool canScrollInDirection(const Node* container, WebFocusType type) {

switch (type) {

case WebFocusTypeLeft:

return (container->layoutObject()->style()->overflowX() !=

- OverflowHidden &&

+ EOverflow::Hidden &&

container->layoutBox()->scrollLeft() > 0);

case WebFocusTypeUp:

return (container->layoutObject()->style()->overflowY() !=

- OverflowHidden &&

+ EOverflow::Hidden &&

container->layoutBox()->scrollTop() > 0);

case WebFocusTypeRight:

return (container->layoutObject()->style()->overflowX() !=

- OverflowHidden &&

+ EOverflow::Hidden &&

container->layoutBox()->scrollLeft() +

container->layoutBox()->clientWidth() <

container->layoutBox()->scrollWidth());

case WebFocusTypeDown:

return (container->layoutObject()->style()->overflowY() !=

- OverflowHidden &&

+ EOverflow::Hidden &&

container->layoutBox()->scrollTop() +

container->layoutBox()->clientHeight() <

container->layoutBox()->scrollHeight());

@@ -626,9 +626,11 @@ bool canBeScrolledIntoView(WebFocusType type, const FocusCandidate& candidate) {

LayoutRect parentRect = nodeRectInAbsoluteCoordinates(&parentNode);

if (!candidateRect.intersects(parentRect)) {

if (((type == WebFocusTypeLeft || type == WebFocusTypeRight) &&

- parentNode.layoutObject()->style()->overflowX() == OverflowHidden) ||

+ parentNode.layoutObject()->style()->overflowX() ==

+ EOverflow::Hidden) ||

((type == WebFocusTypeUp || type == WebFocusTypeDown) &&

- parentNode.layoutObject()->style()->overflowY() == OverflowHidden))

+ parentNode.layoutObject()->style()->overflowY() ==

+ EOverflow::Hidden))

return false;

}

if (parentNode == candidate.enclosingScrollableBox)