Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2568973002: chromeos: Replace user image notifications with observer (Closed)

Created:
4 years ago by xiyuan
Modified:
4 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, alemate+watch_chromium.org, sadrul, michaelpg+watch-md-settings_chromium.org, achuith+watch_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, kalyank, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Replace user image notifications with observer BUG=670422 Committed: https://crrev.com/66e4177886b272950cafc7dabed256025dcf7013 Cr-Commit-Position: refs/heads/master@{#438302}

Patch Set 1 #

Patch Set 2 : update FakeChromeUserManager to fix tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -248 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.h View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 3 chunks +22 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 5 chunks +27 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 7 chunks +7 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 5 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 3 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc View 2 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler.h View 4 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M components/user_manager/user_manager.h View 2 chunks +17 lines, -0 lines 0 comments Download
M components/user_manager/user_manager.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
xiyuan
4 years ago (2016-12-12 20:52:03 UTC) #3
Alexander Alekseev
lgtm
4 years ago (2016-12-12 22:37:54 UTC) #5
xiyuan
stevenjb, please help with owner's review of the following: chrome/browser/ui/ash/* chrome/browser/ui/webui/options/* jam, please approve change ...
4 years ago (2016-12-12 23:32:13 UTC) #7
jam
lgtm
4 years ago (2016-12-13 01:28:43 UTC) #8
stevenjb
lgtm
4 years ago (2016-12-13 18:41:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568973002/20001
4 years ago (2016-12-13 19:33:28 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/325038)
4 years ago (2016-12-13 19:45:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568973002/40001
4 years ago (2016-12-13 20:22:38 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-13 21:58:32 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-13 22:00:54 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66e4177886b272950cafc7dabed256025dcf7013
Cr-Commit-Position: refs/heads/master@{#438302}

Powered by Google App Engine
This is Rietveld 408576698