Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 2568973002: chromeos: Replace user image notifications with observer (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 1a5aa8f3e509e3ea963ae016e8f15235028189d0..605acd26cecdd4f6c4b722fbb1cd1eb74de5fe69 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -941,6 +941,7 @@ void BrowserOptionsHandler::Uninitialize() {
Profile::FromWebUI(web_ui()));
if (arc_prefs)
arc_prefs->RemoveObserver(this);
+ user_manager::UserManager::Get()->RemoveObserver(this);
#endif
}
@@ -1010,8 +1011,7 @@ void BrowserOptionsHandler::InitializeHandler() {
#endif
#if defined(OS_CHROMEOS)
- registrar_.Add(this, chrome::NOTIFICATION_LOGIN_USER_IMAGE_CHANGED,
- content::NotificationService::AllSources());
+ user_manager::UserManager::Get()->AddObserver(this);
#endif
registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
content::Source<ThemeService>(
@@ -1370,11 +1370,6 @@ void BrowserOptionsHandler::Observe(
case chrome::NOTIFICATION_BROWSER_THEME_CHANGED:
ObserveThemeChanged();
break;
-#if defined(OS_CHROMEOS)
- case chrome::NOTIFICATION_LOGIN_USER_IMAGE_CHANGED:
- UpdateAccountPicture();
- break;
-#endif
case chrome::NOTIFICATION_GLOBAL_ERRORS_CHANGED:
// Update our sync/signin status display.
OnStateChanged();
@@ -1994,6 +1989,10 @@ void BrowserOptionsHandler::OnAppReadyChanged(
}
}
+void BrowserOptionsHandler::OnUserImageChanged(const user_manager::User& user) {
+ UpdateAccountPicture();
+}
+
void BrowserOptionsHandler::UpdateAndroidSettingsAppState(bool visible) {
base::FundamentalValue is_visible(visible);
web_ui()->CallJavascriptFunctionUnsafe(

Powered by Google App Engine
This is Rietveld 408576698