Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 2568973002: chromeos: Replace user image notifications with observer (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
index 365b31c06f6d05c7f975d34303887cee44b4bcd6..4290d407de93ad3c3ca38b71c831244e4eb2158a 100644
--- a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
@@ -116,18 +116,13 @@ void ChangePictureHandler::RegisterMessages() {
}
void ChangePictureHandler::OnJavascriptAllowed() {
- registrar_.Add(this, chrome::NOTIFICATION_PROFILE_IMAGE_UPDATED,
- content::NotificationService::AllSources());
- registrar_.Add(this, chrome::NOTIFICATION_PROFILE_IMAGE_UPDATE_FAILED,
- content::NotificationService::AllSources());
- registrar_.Add(this, chrome::NOTIFICATION_LOGIN_USER_IMAGE_CHANGED,
- content::NotificationService::AllSources());
+ user_manager::UserManager::Get()->AddObserver(this);
camera_observer_.Add(CameraPresenceNotifier::GetInstance());
}
void ChangePictureHandler::OnJavascriptDisallowed() {
- registrar_.RemoveAll();
+ user_manager::UserManager::Get()->RemoveObserver(this);
camera_observer_.Remove(CameraPresenceNotifier::GetInstance());
}
@@ -382,20 +377,18 @@ void ChangePictureHandler::OnCameraPresenceCheckDone(bool is_camera_present) {
SetCameraPresent(is_camera_present);
}
-void ChangePictureHandler::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- if (type == chrome::NOTIFICATION_PROFILE_IMAGE_UPDATED) {
- // User profile image has been updated.
- SendProfileImage(*content::Details<const gfx::ImageSkia>(details).ptr(),
- false);
- } else if (type == chrome::NOTIFICATION_LOGIN_USER_IMAGE_CHANGED) {
- // Not initialized yet.
- if (previous_image_index_ == user_manager::User::USER_IMAGE_INVALID)
- return;
- SendSelectedImage();
- }
+void ChangePictureHandler::OnUserImageChanged(const user_manager::User& user) {
+ // Not initialized yet.
+ if (previous_image_index_ == user_manager::User::USER_IMAGE_INVALID)
+ return;
+ SendSelectedImage();
+}
+
+void ChangePictureHandler::OnUserProfileImageUpdated(
+ const user_manager::User& user,
+ const gfx::ImageSkia& profile_image) {
+ // User profile image has been updated.
+ SendProfileImage(profile_image, false);
}
gfx::NativeWindow ChangePictureHandler::GetBrowserWindow() const {

Powered by Google App Engine
This is Rietveld 408576698