Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2568713002: [stubs] Fixing issues found by machine graph verifier in code stubs. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fixing issues found by machine graph verifier in code stubs. BUG= Committed: https://crrev.com/9978f90381a41f9abe5d4d2f95ae6848ed732098 Cr-Commit-Position: refs/heads/master@{#41651}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -165 lines) Patch
M src/builtins/builtins.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/builtins/builtins-internal.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-number.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/code-stub-assembler.h View 4 chunks +62 lines, -34 lines 0 comments Download
M src/code-stub-assembler.cc View 21 chunks +68 lines, -101 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/ic/accessor-assembler.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 5 chunks +12 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (17 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-12 14:30:05 UTC) #10
Camillo Bruni
LGTM with nits https://codereview.chromium.org/2568713002/diff/40001/src/builtins/builtins.cc File src/builtins/builtins.cc (right): https://codereview.chromium.org/2568713002/diff/40001/src/builtins/builtins.cc#newcode114 src/builtins/builtins.cc:114: bool sav_csa_verify = FLAG_csa_verify; nit: saved_csa_verify ...
4 years ago (2016-12-12 15:17:37 UTC) #13
Igor Sheludko
https://codereview.chromium.org/2568713002/diff/40001/src/builtins/builtins.cc File src/builtins/builtins.cc (right): https://codereview.chromium.org/2568713002/diff/40001/src/builtins/builtins.cc#newcode114 src/builtins/builtins.cc:114: bool sav_csa_verify = FLAG_csa_verify; On 2016/12/12 15:17:37, Camillo Bruni ...
4 years ago (2016-12-12 15:25:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568713002/80001
4 years ago (2016-12-12 15:25:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years ago (2016-12-12 15:53:26 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-12 15:54:07 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9978f90381a41f9abe5d4d2f95ae6848ed732098
Cr-Commit-Position: refs/heads/master@{#41651}

Powered by Google App Engine
This is Rietveld 408576698